Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AND-4] ThreadList improvements #5455

Merged
merged 89 commits into from
Nov 20, 2024
Merged

[AND-4] ThreadList improvements #5455

merged 89 commits into from
Nov 20, 2024

Conversation

VelikovPetar
Copy link
Contributor

@VelikovPetar VelikovPetar commented Oct 23, 2024 •
edited
Loading

🎯 Goal

  • Implement missing event handling related to Threads
  • Expose ThreadList composable component as public API
  • Update the compose sample app with a bottom bar for switching between Chats and Threads
  • Add ThreadList docs (to be added in the new docs repo)

Note: Offline support is done separately in a different PR

🛠 Implementation details

  • Add/improve handling for the following web socket events: NotificationChannelDeletedEvent, NotificationThreadMessageNewEvent, NotificationMarkUnreadEvent, MessageReadEvent, MessageDeletedEvent
  • Add optimistic state updates of the QueryThreadsState in the state plugin listeners: DeleteMessageListener, DeleteReactionListener, EditMessageListener, SendAttachmentListener, SendGiphyListener, SendMessageListener, SendReactionListener, ShuffleGiphyListener
  • Make ThreadList/ThreadItem configurable via slot-composable
  • Adjust markRead/markUnread logic in MessageListController to support marking threads as read/unread

🧪 Testing

  1. Install compose sample app
  2. Open Threads tab
  3. Play around with different scenarios:
  • open thread
  • mark thread message as unread
  • add a new reply to a thread with a different user
  • delete a message from a thread with a different user
  • delete a thread parent with a different user

PetarVelikov added 30 commits October 9, 2024 09:32
[PBE-3749] Update ThreadsApi to match the definition.
b83a7bc
[PBE-3749] Register "notification.thread_message_new" EventType.
9ac769b
Merge branch 'refs/heads/develop' into feature/threads_v2
c5187ae
[PBE-3749] Implement initial state-management for 'Query Threads'.
e338150
[PBE-3749] Implement ThreadList component.
ce4ab6d
Merge branch 'refs/heads/develop' into feature/threads_v2
8d30835
[PBE-3749] Implement 'Threads' tab in compose sample app.
fdb1ac1
[PBE-3749] FIx pagination logic and add a threshold.
13400dc
[PBE-3749] Add queryThreads preconditions checks.
7a44105
[PBE-3749] Revert ktlint commit.
7ccf42b
[PBE-3749] Remove redundant state update in ThreadListController.
7bf4d3f
[PBE-3749] Add handling for different ChatEvents.
c058190
Merge branch 'refs/heads/develop' into feature/threads_v2
8486cde
[PBE-3749] Remove redundant coroutine creation and docs.
361e754
[PBE-3749] Fix detekt and spotless.
2e8c1b1
Revert "[PBE-3749] Implement 'Threads' tab in compose sample app."
fbc9b3d 
This reverts commit fdb1ac1
Revert "Revert "[PBE-3749] Implement 'Threads' tab in compose sample …
cd01294 
…app.""

This reverts commit fbc9b3d.
Revert "[PBE-3749] Implement 'Threads' tab in compose sample app."
b856073 
This reverts commit fdb1ac1
[PBE-3749] Hide threads-related public apis.
76e5f54
Merge branch 'refs/heads/develop' into feature/threads_v2
6fc64d8 
# Conflicts:
#	stream-chat-android-compose/src/main/res/values/strings.xml
[PBE-3749] Fix PR remarks related DTOs.
b88eca7
[PBE-3749] Fix wrong composable preview.
b91a89c
[PBE-3749] Use inheritScope to create ThreadListController coroutine …
3560186 
…scope.
Merge branch 'refs/heads/develop' into feature/threads_v2
de906ea
[PBE-3749] Implement ChatClient::markThreadRead operation.
72d3689
[PBE-3749] Update CHANGELOG for markThreadRead.
10e5c9d
[PBE-3749] Fix failing test.
93f8f39
[PBE-3749] Separate markThreadRead from markRead.
0b7d384
[PBE-3749] Implement unreadThreads logic as part of the GlobalState.
321907f
Merge branch 'refs/heads/develop' into feature/threads_v2_global_unre…
47e7849 
…ad_threads_state
PetarVelikov added 13 commits November 5, 2024 14:44
Merge branch 'refs/heads/develop' into feature/threads_v2_improvements
c58e458
[PBE-3749] Add 'Mark thread as unread' handling.
a823a89
Merge branch 'refs/heads/develop' into feature/threads_v2
e153761
Merge branch 'refs/heads/feature/threads_v2' into feature/threads_v2_…
b159d5c 
…improvements
Merge branch 'refs/heads/develop' into feature/threads_v2
aec80bb
Merge branch 'refs/heads/feature/threads_v2' into feature/threads_v2_…
acca8de 
…improvements
Merge branch 'refs/heads/develop' into feature/threads_v2
a317992
Merge branch 'refs/heads/feature/threads_v2' into feature/threads_v2_…
6ade7ba 
…improvements
Merge branch 'develop' into feature/threads_v2
7941d4e 
# Conflicts:
#	stream-chat-android-compose/api/stream-chat-android-compose.api
[PBE-3749] apply spotless.
55e71f8
Merge branch 'feature/threads_v2' into feature/threads_v2_improvements
e52aede
Merge branch 'develop' into feature/threads_v2_improvements
23b3b09 
# Conflicts:
#	stream-chat-android-client/src/main/java/io/getstream/chat/android/client/ChatClient.kt
#	stream-chat-android-client/src/main/java/io/getstream/chat/android/client/api2/model/dto/ThreadDtos.kt
#	stream-chat-android-compose/api/stream-chat-android-compose.api
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/threads/ThreadItem.kt
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/threads/ThreadList.kt
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/ui/threads/UnreadThreadsBanner.kt
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/threads/ThreadListViewModel.kt
#	stream-chat-android-compose/src/main/java/io/getstream/chat/android/compose/viewmodel/threads/ThreadsViewModelFactory.kt
#	stream-chat-android-core/src/main/java/io/getstream/chat/android/models/Thread.kt
#	stream-chat-android-state/src/main/java/io/getstream/chat/android/state/event/handler/internal/EventHandlerSequential.kt
#	stream-chat-android-state/src/main/java/io/getstream/chat/android/state/extensions/ChatClient.kt
#	stream-chat-android-state/src/main/java/io/getstream/chat/android/state/plugin/listener/internal/QueryThreadsListenerState.kt
#	stream-chat-android-state/src/main/java/io/getstream/chat/android/state/plugin/logic/internal/LogicRegistry.kt
#	stream-chat-android-state/src/main/java/io/getstream/chat/android/state/plugin/state/querythreads/internal/QueryThreadsMutableState.kt
#	stream-chat-android-ui-common/src/main/kotlin/io/getstream/chat/android/ui/common/state/threads/ThreadListState.kt
[PBE-3479] Post merge clean-up.
5708cad
@VelikovPetar VelikovPetar marked this pull request as ready for review November 18, 2024 11:10
@VelikovPetar VelikovPetar requested a review from a team as a code owner November 18, 2024 11:10
@JcMinarro JcMinarro force-pushed the feature/threads_v2_improvements branch from 7947e5a to c162aae Compare November 19, 2024 23:58
@JcMinarro JcMinarro force-pushed the feature/threads_v2_improvements branch from c162aae to c111fbc Compare November 20, 2024 00:07
@JcMinarro JcMinarro merged commit 42a3aed into develop Nov 20, 2024
9 checks passed
@JcMinarro JcMinarro deleted the feature/threads_v2_improvements branch November 20, 2024 06:39
@aleksandar-apostolov aleksandar-apostolov changed the title [PBE-3749] ThreadList improvements [AND-4] ThreadList improvements Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JcMinarro JcMinarro JcMinarro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VelikovPetar @JcMinarro @aleksandar-apostolov