Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PBE-3749] Implement ChatClient::markThreadUnread operation. #5457

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

VelikovPetar
Copy link
Contributor

🎯 Goal

Implement the ChatClient.markThreadUnread operation. It will be used as part of the whole Threads V2 implementation.

🛠 Implementation details

  • Extend the MarkUnreadRequest with thread_id filed (as per the api documentation)
  • Implement new markThreadUnread (similar to markUnread) methods on ChatClient and ChannelClient

🎨 UI Changes

NA

🧪 Testing

Currently not used

☑️Contributor Checklist

General

  • I have signed the Stream CLA (required)
  • Assigned a person / code owner group (required)
  • Thread with the PR link started in a respective Slack channel (#android-chat-core or #android-chat-ui) (required)
  • PR targets the develop branch
  • PR is linked to the GitHub issue it resolves

Code & documentation

  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (KDocs, docusaurus, tutorial)

☑️Reviewer Checklist

  • UI Components sample runs & works
  • Compose sample runs & works
  • UI Changes correct (before & after images)
  • Bugs validated (bugfixes)
  • New feature tested and works
  • Release notes and docs clearly describe changes
  • All code we touched has new or updated KDocs

🎉 GIF

Please provide a suitable gif that describes your work on this pull request

@VelikovPetar VelikovPetar marked this pull request as ready for review October 28, 2024 08:18
@VelikovPetar VelikovPetar requested a review from a team as a code owner October 28, 2024 08:18
@JcMinarro JcMinarro enabled auto-merge (rebase) November 5, 2024 12:30
@JcMinarro JcMinarro force-pushed the feature/threads_v2_mark_thread_as_unread branch from 7123e24 to 105552c Compare November 5, 2024 12:38
@JcMinarro JcMinarro merged commit 6846c1f into develop Nov 5, 2024
7 checks passed
@JcMinarro JcMinarro deleted the feature/threads_v2_mark_thread_as_unread branch November 5, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants