feat: allow optimistically added messages in local state #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -9 B (0%) Total Size: 314 kB
ℹ️ View Unchanged
|
6 tasks
vishalnarkhede
requested review from
ferhatelmas,
gumuz,
madsroskar and
vanGalilea
as code owners
vanGalilea
reviewed
Nov 1, 2022
vanGalilea
approved these changes
Nov 11, 2022
vanGalilea
approved these changes
Nov 11, 2022
Closed
vishalnarkhede
added a commit
that referenced
this pull request
Nov 15, 2022
…)" This reverts commit 16d9363.
Merged
vishalnarkhede
added a commit
that referenced
this pull request
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Changes to support optimistic DB update - GetStream/stream-chat-react-native#1758
2nd param to function
addMessagesSorteddetermines weather messages being added may already exist in state or not. If they already exist, that means they were optimistically added, but timestamp of the message needs to be updated with the one stored on backend.