feat: added 'pending' property to message #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishalnarkhede
commented
Jun 20, 2023
| pending_message_metadata?: Record<string, string>; | ||
| skip_enrich_url?: boolean; | ||
| skip_push?: boolean; | ||
| }, | ||
| ) { | ||
| if (options?.is_pending_message !== undefined && !this._client._isUsingServerAuth()) { |
There was a problem hiding this comment.
This check has been moved to backend.
vishalnarkhede
commented
Jun 20, 2023
| @@ -844,35 +844,3 @@ describe('Channel _initializeState', () => { | |||
| expect(Object.keys(channel.state.members)).deep.to.be.equal(['alice']); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('pending message', () => { | |||
There was a problem hiding this comment.
This unit test didn't make sense anymore since entire credential check has been moved to backend.
|
Size Change: -229 B (0%) Total Size: 318 kB
|
totalimmersion
previously approved these changes
Jun 20, 2023
vishalnarkhede
force-pushed
the
pending-property-renaming
branch
from
1b4b340
to
8f691b8
Compare
MartinCupela
approved these changes
Jul 3, 2023
vanGalilea
approved these changes
Jul 3, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
Changelog