-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing property 'silent' to MessageBase type #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: 0 B Total Size: 318 kB ℹ️ View Unchanged
|
When adding it to Lines 519 to 547 in 31da90b
|
szuperaz
previously approved these changes
Aug 14, 2023
oliverlaz
previously approved these changes
Aug 14, 2023
szuperaz
approved these changes
Aug 16, 2023
oliverlaz
approved these changes
Aug 16, 2023
vishalnarkhede
approved these changes
Aug 21, 2023
This was referenced Aug 21, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLA
Description of the changes, What, Why and How?
According to the JS SDK documentation, the
Message
object passed as the first argument toChannel.sendMessage()
method should optionally carrysilent
property. This property was however not declared in the type definition. This PR adds the property to the underlyingMessageBase
type definition.