Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove the unnecessary remapping of chat-core import #1837

Merged
merged 1 commit into from
Nov 30, 2022
Merged

fix: remove the unnecessary remapping of chat-core import #1837

merged 1 commit into from
Nov 30, 2022

Conversation

santhoshvai
Copy link
Member

@santhoshvai santhoshvai commented Nov 30, 2022 •
edited
Loading

🎯 Goal

We found remapping of stream-chat-react-native in tsconfig to be ugly. This PR removes it.

🛠 Implementation details

NA

🎨 UI Changes

NA

🧪 Testing

yarn build must complete successfully.

☑️ Checklist

  • I have signed the Stream CLA (required)
  • PR targets the develop branch
  • Documentation is updated
  • New code is tested in main example apps, including all possible scenarios
    • SampleApp iOS and Android
    • Expo iOS and Android

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@santhoshvai santhoshvai merged commit 25815d5 into develop Nov 30, 2022
@santhoshvai santhoshvai deleted the fix/remove-tsconfig-path branch November 30, 2022 09:29
@github-actions github-actions bot mentioned this pull request Dec 1, 2022
Merged
6 tasks
@vishalnarkhede
Copy link
Contributor

🎉 This PR is included in version 5.6.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishalnarkhede vishalnarkhede vishalnarkhede approved these changes

@vanGalilea vanGalilea Awaiting requested review from vanGalilea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@santhoshvai @vishalnarkhede