feat(Reactions): add proper error handling to getImageDimensions

GetStream · Feb 28, 2023 · 7bc4242 · 7bc4242
1 parent bd250f1
commit 7bc4242
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/components/Reactions/SpriteImage.tsx b/src/components/Reactions/SpriteImage.tsx
@@ -24,7 +24,7 @@ export const SpriteImage = ({
   const [[spriteWidth, spriteHeight], setSpriteDimensions] = useState([0, 0]);
 
   useEffect(() => {
-    getImageDimensions(spriteUrl).then(setSpriteDimensions);
+    getImageDimensions(spriteUrl).then(setSpriteDimensions).catch(console.error);
   }, [spriteUrl]);
 
   const [x, y] = position;
@@ -42,6 +42,7 @@ export const SpriteImage = ({
 
   return (
     <div
+      data-testid='sprite-image'
       style={{
         backgroundImage: `url('${spriteUrl}')`,
         backgroundPosition: `${x * (100 / (columns - 1))}% ${y * (100 / (rows - 1))}%`,

diff --git a/src/components/Reactions/utils/utils.tsx b/src/components/Reactions/utils/utils.tsx
@@ -19,7 +19,9 @@ export const getImageDimensions = (source: string) =>
       { once: true },
     );
 
-    image.addEventListener('error', reject, { once: true });
+    image.addEventListener('error', () => reject(`Couldn't load image from ${source}`), {
+      once: true,
+    });
 
     image.src = source;
   });