Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: The emoji is not aligned in centre on hovering the emoji. #2094

Closed
piyushpatil4270 opened this issue Sep 13, 2023 · 2 comments · Fixed by #2117
Closed

bug: The emoji is not aligned in centre on hovering the emoji. #2094

piyushpatil4270 opened this issue Sep 13, 2023 · 2 comments · Fixed by #2117
Labels
bug Something isn't working released status:confirmed Described issue has been reproduced by the repo maintainer

Comments

@piyushpatil4270
Copy link

Describe the bug
In the chat app the emojis are not aligned properly inside the circle.
*Screenrecording:
https://github.com/GetStream/stream-chat-react/assets/126204079/50299c27-23ac-41a9-a79e-185d73e45bdb

To Reproduce

Steps to reproduce the behavior:

  1. Go to the chat
  2. Click on the emoji section
  3. Hover the emojis
  4. See error

Expected behavior
The emojis should be aligned properly inside the circle

Package version

  • stream-chat-react:
  • stream-chat-css:
  • stream-chat-js:

Desktop

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]
@piyushpatil4270 piyushpatil4270 added bug Something isn't working status: unconfirmed labels Sep 13, 2023
@MartinCupela
Copy link
Contributor

@piyushpatil4270 thank you for raising this issue. We plan to tackle it in the near future

@MartinCupela MartinCupela added status:confirmed Described issue has been reproduced by the repo maintainer and removed status: unconfirmed labels Sep 28, 2023
@arnautov-anton arnautov-anton mentioned this issue Nov 15, 2023
Merged
arnautov-anton added a commit that referenced this issue Nov 27, 2023
@arnautov-anton
fix(emoji-mart): simplify EmojiPicker & emojiSearchIndex (#2117)
3657ed0 
BREAKING CHANGE: `EmojiPicker` & `EmojiIndex` signatures changed,
`EmojiIndex` has been renamed to `emojiSearchIndex`, both `EmojiPicker`
& `emojiSearchIndex` are now optional, see release guide for more
information
BREAKING CHANGE: `useImageFlagEmojisOnWindow` flag now requires extra
style sheet import, see release guide for more information

Fixes: #2116
Fixes: #2094
arnautov-anton added a commit that referenced this issue Nov 27, 2023
@arnautov-anton
fix(emoji-mart): simplify EmojiPicker & emojiSearchIndex (#2117)
8fd13e3 
BREAKING CHANGE: `EmojiPicker` & `EmojiIndex` signatures changed,
`EmojiIndex` has been renamed to `emojiSearchIndex`, both `EmojiPicker`
& `emojiSearchIndex` are now optional, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more
information
BREAKING CHANGE: `useImageFlagEmojisOnWindow` flag now requires extra
style sheet import, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information

Fixes: #2116
Fixes: #2094
arnautov-anton added a commit that referenced this issue Nov 27, 2023
@arnautov-anton
fix(emoji-mart): simplify EmojiPicker & emojiSearchIndex (#2117)
a6e0a87 
Fixes: #2116
Fixes: #2094

BREAKING CHANGE: `EmojiPicker` & `EmojiIndex` signatures changed, `EmojiIndex` has been renamed to `emojiSearchIndex`, both `EmojiPicker` & `emojiSearchIndex` are now optional, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
BREAKING CHANGE: `useImageFlagEmojisOnWindow` flag now requires extra style sheet import, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
github-actions bot pushed a commit that referenced this issue Nov 27, 2023
@semantic-release-bot
chore(release): 11.0.0 [skip ci]
a9a5193 
## [11.0.0](v10.20.1...v11.0.0) (2023-11-27)

### ⚠ BREAKING CHANGES

* **emoji-mart:** `EmojiPicker` & `EmojiIndex` signatures changed, `EmojiIndex` has been renamed to `emojiSearchIndex`, both `EmojiPicker` & `emojiSearchIndex` are now optional, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
* **emoji-mart:** `useImageFlagEmojisOnWindow` flag now requires extra style sheet import, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
* **emoji-mart:** `reactionOptions` signature has changed, see [release guide](https://github.com/GetStream/stream-chat-react/blob/v11.0.0/docusaurus/docs/React/release-guides/upgrade-to-v11.mdx) for more information
* the first argument to `doSendMessageRequest` is now Channel instance instead of `Channel.cid`
* apply the remark plugins `keepLineBreaksPlugin`, `htmlToTextPlugin` as a part of the default message text parsing, upgrade `unified` libraries

### Bug Fixes

* **emoji-mart:** new reactions  ([#1947](#1947)) ([14bef23](14bef23)), closes [#1935](#1935) [#1637](#1637) [#1437](#1437) [#2159](#2159)
* **emoji-mart:** simplify EmojiPicker & emojiSearchIndex ([#2117](#2117)) ([a6e0a87](a6e0a87)), closes [#2116](#2116) [#2094](#2094)

### Features

* apply keepLineBreaksPlugin & htmlToTextPlugin plugins to text rendering by default ([#2169](#2169)) ([e8047f2](e8047f2)), closes [#2170](#2170) [/github.com/GetStream/stream-chat-react/blob/f0bc7ba2532760cabb1db01e685a35bd3b0b64c5/src/components/Message/renderText/renderText.tsx#L158](https://github.com/GetStream//github.com/GetStream/stream-chat-react/blob/f0bc7ba2532760cabb1db01e685a35bd3b0b64c5/src/components/Message/renderText/renderText.tsx/issues/L158)
* export MessageListNotifications and LinkPreviewList components and component props ([#2181](#2181)) ([a5a7e5a](a5a7e5a))
* require Channel instance as the first argument to doSendMessageRequest ([#2171](#2171)) ([2a06b88](2a06b88))

### Chores

* **deps:** bump stream-chat from 8.14.0 to 8.14.2 ([#2179](#2179)) ([4e6a59d](4e6a59d))
* **deps:** bump stream-chat from 8.14.2 to 8.14.3 ([#2185](#2185)) ([3dd8dab](3dd8dab))
@stream-ci-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 11.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released status:confirmed Described issue has been reproduced by the repo maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(emoji-mart): simplify EmojiPicker & emojiSearchIndex GetStream/stream-chat-react
3 participants
@stream-ci-bot @MartinCupela @piyushpatil4270