fix: prevent ignoring the clearSearchOnClickOutside search param on mobile #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MartinCupela
previously approved these changes
Jul 7, 2023
MartinCupela
force-pushed
the
fix/clear-search-on-click-outside
branch
from
ec76542
to
0d2f039
Compare
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #2039 +/- ##
========================================
Coverage 82.22% 82.22%
========================================
Files 263 263
Lines 6432 6432
Branches 1814 1814
========================================
Hits 5289 5289
Misses 831 831
Partials 312 312
☔ View full report in Codecov by Sentry. |
MartinCupela
changed the title
MartinCupela
approved these changes
Jul 9, 2023
|
🎉 This PR is included in version 10.8.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
Fixes an issue where
clearSearchOnClickOutsidewould be ignored when the navigation in mobile view is open.