Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep a list of unique channels in the ChannelList when paginating #2115

Conversation

MartinCupela
Copy link
Contributor

🎯 Goal

Keep a list of unique channels in the ChannelList when paginating.

@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (cd07418) 83.16% compared to head (127937a) 83.21%.
Report is 1 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2115      +/-   ##
===========================================
+ Coverage    83.16%   83.21%   +0.04%     
===========================================
  Files          293      293              
  Lines         7011     7012       +1     
  Branches      1996     1996              
===========================================
+ Hits          5831     5835       +4     
+ Misses         850      848       -2     
+ Partials       330      329       -1     
Files Coverage Δ
...mponents/ChannelList/hooks/usePaginatedChannels.ts 97.14% <100.00%> (+8.90%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MartinCupela MartinCupela merged commit 11173e1 into develop Oct 6, 2023
3 of 4 checks passed
@MartinCupela MartinCupela deleted the fix/keep-unique-channels-while-paginating-in-channel-list branch October 6, 2023 16:43
@MartinCupela MartinCupela mentioned this pull request Oct 6, 2023
github-actions bot pushed a commit that referenced this pull request Oct 6, 2023
# [10.13.0](v10.12.0...v10.13.0) (2023-10-06)

### Bug Fixes

* on pagination keep a unique list of channels in the ChannelList ([#2115](#2115)) ([11173e1](11173e1))

### Features

* add initializeOnMount prop to ChannelProps ([#2113](#2113)) ([db18efd](db18efd))
* allow to conditionally display MessageInput's send button through MessageInputProps ([#2109](#2109)) ([cd07418](cd07418))
@github-actions
Copy link

github-actions bot commented Oct 6, 2023

🎉 This PR is included in version 10.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants