feat: add ThreadList and ThreadProvider (Threads 2.0) #2407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
force-pushed
the
feat/threads-v2
branch
from
eb1dfe5
to
386105c
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
2 times, most recently
from
d60dd9b
to
ffc1389
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
2 times, most recently
from
cb06b65
to
e5e0cd9
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
from
0b4c146
to
d897374
Compare
MartinCupela
force-pushed
the
master
branch
2 times, most recently
from
295c64b
to
cd5542d
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
from
a5173e8
to
b39a276
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
3 times, most recently
from
7be0df7
to
a624062
Compare
myandrienko
force-pushed
the
feat/threads-v2
branch
from
1456257
to
8f19a9e
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
from
d943262
to
56039ae
Compare
arnautov-anton
force-pushed
the
feat/threads-v2
branch
from
b3555bb
to
bd094cc
Compare
myandrienko
reviewed
Aug 29, 2024
| VirtualMessage: props.VirtualMessage, | ||
| }), | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| [props.reactionOptions], |
There was a problem hiding this comment.
I think this was by design, changing overrides "in runtime" is not a good idea.
|
Size Change: +18.8 kB (+1.82%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2407 +/- ##
==========================================
- Coverage 85.52% 84.50% -1.03%
==========================================
Files 369 384 +15
Lines 7864 8105 +241
Branches 1908 1955 +47
==========================================
+ Hits 6726 6849 +123
- Misses 1046 1165 +119
+ Partials 92 91 -1 ☔ View full report in Codecov by Sentry. |
myandrienko
approved these changes
Sep 4, 2024
arnautov-anton
force-pushed
the
feat/threads-v2
branch
from
79e9b6e
to
ad615d4
Compare
arnautov-anton
added a commit
that referenced
this pull request
Sep 4, 2024
🚂 GetStream/stream-chat-js#1330 This PR adds components for implementing a thread list view: ThreadList and ChatView. It also adds support for reactive state stores, like the ones that handle the thread list logic in the client. Implements a binding from the reactive state store in the client to React components. Implements a thread list. The component itself consists mostly of binding to the `ThreadManager` instance in the client. The Thread component was modified to optionally use a reactive `Thread` instance from the `ThreadContext`. The component checks if `ThreadContext` is provided, and if so uses the thread instance from that context. Otherwise, it falls back to the `ChannelContext` as usual. Currently, we use `ThreadContext` in the thread list view, where it is provided by the `ChatView.ThreadAdapter` component. Note that even when `ThreadContext` is used, `ChannelContext` also must be provided. Most our components, including the ones used in threads, still expect the channel context to be there. A set of components implementing a simple in-memory router to switch between channel view and thread list view. Using it is totally optional. Most integrations will probably use their own router instead. Still, nice to have something out-of-the-box. A new way to provide component overrides. Previously we allowed passing component overrides as props to `Channel` component, and then in some nested components as well, although not consistently. `WithComponents` is a new recommended way to provide component overrides, which requires far less prop drilling and nests nicely. --------- Co-authored-by: Matvei Andrienko <m.y.andrienko@outlook.com> BREAKING CHANGE: ComponentContext no longer provides any defaults
arnautov-anton
changed the title
arnautov-anton
added a commit
that referenced
this pull request
Sep 4, 2024
🚂 GetStream/stream-chat-js#1330 This PR adds components for implementing a thread list view: ThreadList and ChatView. It also adds support for reactive state stores, like the ones that handle the thread list logic in the client. Implements a binding from the reactive state store in the client to React components. Implements a thread list. The component itself consists mostly of binding to the `ThreadManager` instance in the client. The Thread component was modified to optionally use a reactive `Thread` instance from the `ThreadContext`. The component checks if `ThreadContext` is provided, and if so uses the thread instance from that context. Otherwise, it falls back to the `ChannelContext` as usual. Currently, we use `ThreadContext` in the thread list view, where it is provided by the `ChatView.ThreadAdapter` component. Note that even when `ThreadContext` is used, `ChannelContext` also must be provided. Most our components, including the ones used in threads, still expect the channel context to be there. A set of components implementing a simple in-memory router to switch between channel view and thread list view. Using it is totally optional. Most integrations will probably use their own router instead. Still, nice to have something out-of-the-box. A new way to provide component overrides. Previously we allowed passing component overrides as props to `Channel` component, and then in some nested components as well, although not consistently. `WithComponents` is a new recommended way to provide component overrides, which requires far less prop drilling and nests nicely. BREAKING CHANGE: ComponentContext no longer provides any defaults --------- Co-authored-by: Matvei Andrienko <m.y.andrienko@outlook.com>
github-actions bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
## [12.0.0-rc.11](v12.0.0-rc.10...v12.0.0-rc.11) (2024-09-04) ### ⚠ BREAKING CHANGES * ComponentContext no longer provides any defaults ### Bug Fixes * MessageActions adjustments ([#2472](#2472)) ([fbd1b6f](fbd1b6f)) * quote replies in threads ([#2487](#2487)) ([0e4a6f1](0e4a6f1)) ### Features * add ThreadList and ThreadProvider (Threads 2.0) ([#2407](#2407)) ([941707d](941707d)) ### Chores * **deps:** bump version of stream-chat in peerDeps ([#2481](#2481)) ([466385d](466385d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚂 GetStream/stream-chat-js#1330
This PR adds components for implementing a thread list view: ThreadList and ChatView. It also adds support for reactive state stores, like the ones that handle the thread list logic in the client.
useStateStore
Implements a binding from the reactive state store in the client to React components.
ThreadList
Implements a thread list. The component itself consists mostly of binding to the
ThreadManagerinstance in the client.Thread
The Thread component was modified to optionally use a reactive
Threadinstance from theThreadContext. The component checks ifThreadContextis provided, and if so uses the thread instance from that context. Otherwise, it falls back to theChannelContextas usual.Currently, we use
ThreadContextin the thread list view, where it is provided by theChatView.ThreadAdaptercomponent.Note that even when
ThreadContextis used,ChannelContextalso must be provided. Most our components, including the ones used in threads, still expect the channel context to be there.ChatView
A set of components implementing a simple in-memory router to switch between channel view and thread list view. Using it is totally optional. Most integrations will probably use their own router instead. Still, nice to have something out-of-the-box.
WithComponents
A new way to provide component overrides. Previously we allowed passing component overrides as props to
Channelcomponent, and then in some nested components as well, although not consistently.WithComponentsis a new recommended way to provide component overrides, which requires far less prop drilling and nests nicely.BREAKING CHANGE: ComponentContext no longer provides any defaults