fix: change SuggestionEmoji to extended EmojiSearchIndexResult #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2551 +/- ##
=======================================
Coverage 83.18% 83.18%
=======================================
Files 437 437
Lines 9113 9113
Branches 2232 2232
=======================================
Hits 7581 7581
Misses 1204 1204
Partials 328 328 ☔ View full report in Codecov by Sentry. |
|
Size Change: 0 B Total Size: 1.16 MB ℹ️ View Unchanged
|
oliverlaz
approved these changes
Nov 8, 2024
arnautov-anton
approved these changes
Nov 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
Nov 11, 2024
## [12.5.2](v12.5.1...v12.5.2) (2024-11-11) ### Bug Fixes * change SuggestionEmoji to extended EmojiSearchIndexResult ([#2551](#2551)) ([658d722](658d722))
|
🎉 This PR is included in version 12.5.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
the type
SuggestionItemuses typeSuggestionEmojiwhich is declared as an array (result of emoji search). But this cannot be right as every suggestion item component receives a single data point from an array. This iteration and passing of single objects is done inSuggestionList.Without doing this change, it is impossible to implement custom suggestion list item component, because TS says the component would get single
CommandResponseorUserResponseor an array ofEmojiSearchIndexResults.