fix!: replace StreamChatGenerics with module augmentation #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnautov-anton
requested review from
myandrienko,
isekovanic and
MartinCupela
and removed request for
myandrienko,
isekovanic and
MartinCupela
arnautov-anton
force-pushed
the
fix/remove-stream-chat-generics
branch
from
0a39de2 to
93b9d95
Compare
isekovanic
reviewed
Feb 6, 2025
| const options: ChannelOptions = { state: true, presence: true, limit: 10 }; | ||
| const sort: ChannelSort = { last_message_at: -1, updated_at: -1 }; | ||
|
|
||
| type LocalAttachmentType = Record<string, unknown>; |
There was a problem hiding this comment.
I've yet to see a more beautiful sight than this :D
arnautov-anton
force-pushed
the
fix/remove-stream-chat-generics
branch
from
c5728f7 to
36c3dc3
Compare
|
Size Change: -249 B (-0.02%) Total Size: 1.37 MB
ℹ️ View Unchanged
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2634 +/- ##
==========================================
+ Coverage 81.03% 81.10% +0.07%
==========================================
Files 469 469
Lines 9929 9898 -31
Branches 2348 2344 -4
==========================================
- Hits 8046 8028 -18
+ Misses 1762 1748 -14
- Partials 121 122 +1 ☔ View full report in Codecov by Sentry. |
arnautov-anton
force-pushed
the
fix/remove-stream-chat-generics
branch
11 times, most recently
from
c9d1e66 to
3349707
Compare
arnautov-anton
commented
Feb 12, 2025
Comment on lines
+28
to
+36
| export type StreamMessage = | ||
| // FIXME: we should use only one of the two (either formatted or unformatted) | ||
| (ReturnType<StreamChannelState['formatMessage']> | MessageResponse) & { | ||
| customType?: string; | ||
| errorStatusCode?: number; | ||
| error?: ErrorFromResponse<APIErrorResponse>; | ||
| editing?: boolean; | ||
| date?: Date; | ||
| }; |
There was a problem hiding this comment.
We should revisit StreamMessage and decide what its shape should be as of a "local" message. In my opinion we should treat it as FormattedMessageResponse with some extra properties (lines 31-35), which we sometimes add.
arnautov-anton
force-pushed
the
fix/remove-stream-chat-generics
branch
2 times, most recently
from
e3720c9 to
73f23f0
Compare
arnautov-anton
force-pushed
the
fix/remove-stream-chat-generics
branch
from
73f23f0 to
7d0a418
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎯 Goal
References: GetStream/stream-chat-js#1458
Notable changes:
EventComponentProps.messageproperty with{ event?: Event }to cover for weird edge-caseStreamMessagetype with these properties commonly used across the SDK{ customType?: string; errorStatusCode?: number; editing?: boolean; date?: Date }