Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevented output of empty skip link markup. #337

Open
wants to merge 2 commits into
base: development
Choose a base branch
from
Open

Prevented output of empty skip link markup. #337

wants to merge 2 commits into from

Conversation

christophherr
Copy link
Member

closes #336.

ibes
ibes reviewed Sep 26, 2018
View reviewed changes
Copy link
Contributor

@ibes ibes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you get rid of the (array)?

besides of that, this would also be the solution I found.

@ibes
Copy link
Contributor

ibes commented Sep 27, 2018

Should there be tests added to check for this behaviour?

@christophherr
Copy link
Member Author

Arguably, keeping the (array) would prevent beans_output_skip_links from ever fataling.
The downside is that if you want to shortcircuit the skip links with the filter, you can only use __return_null. Without the casting, you can use __return_false or __return_null in the filter.

I've no strong preference either way.

Yes, tests should be added to beansBuildSkipLinks.php and a few new tests written for beans_output_skip_links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibes ibes ibes left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stop empty skip link markup from outputting
2 participants
@christophherr @ibes