Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: move cli command logic #115

Merged
merged 1 commit into from
Nov 4, 2022
Merged

refactor: move cli command logic #115

merged 1 commit into from
Nov 4, 2022

Conversation

buschNT
Copy link
Collaborator

@buschNT buschNT commented Nov 3, 2022

  • remove ifelse in main
  • rename api folder to cli
  • prepare decoupling of cli from getdeck lib

@buschNT
refactor: move cli command logic
2307e83 
- remove ifelse in __main__
- rename api folder to cli
- prepare decoupling of cli from getdeck lib
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@coveralls
Copy link

Pull Request Test Coverage Report for Build 3390064082

  • 60 of 85 (70.59%) changed or added relevant lines in 10 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 66.122%
Changes Missing Coverage Covered Lines Changed/Added Lines %
getdeck/cli/console.py 10 11 90.91%
getdeck/cli/hosts.py 2 3 66.67%
getdeck/cli/remove.py 4 5 80.0%
getdeck/fetch/fetch.py 2 3 66.67%
getdeck/cli/version.py 3 5 60.0%
getdeck/cli/list.py 2 5 40.0%
getdeck/main.py 19 25 76.0%
getdeck/cli/telemetry.py 6 16 37.5%
Files with Coverage Reduction New Missed Lines %
getdeck/main.py 1 86.96%
Totals Coverage Status
Change from base Build 3389454246: 0.5%
Covered Lines: 1376
Relevant Lines: 2081
💛 - Coveralls

@buschNT buschNT marked this pull request as ready for review November 4, 2022 09:40
@buschNT buschNT merged commit f639c3b into main Nov 4, 2022
@buschNT buschNT deleted the refactor/cli-commands branch November 4, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@buschNT @coveralls