Migrate to gradle, java 17 and fix examples #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexProgrammerDE
force-pushed
the
gradle-java
branch
from
14d0c95 to
0f28b75
Compare
Kas-tle
previously requested changes
Dec 11, 2023
Konicai
requested changes
Dec 12, 2023
|
Also, please just target Java 16 for now since we do not plan to upgrade Geyser to Java 17 until forge is supported. |
|
All requested changes have been done. |
Konicai
requested changes
Dec 15, 2023
|
thank :) |
Konicai
requested changes
Dec 15, 2023
src/main/java/com/github/steveice10/mc/protocol/codec/MinecraftCodec.java
Outdated
Show resolved
Hide resolved
src/main/java/com/github/steveice10/mc/protocol/data/game/entity/metadata/MetadataType.java
Outdated
Show resolved
Hide resolved
# Conflicts: # .github/workflows/deploy.yml # .github/workflows/maven.yml # pom.xml
|
All requested changes are made. |
This reverts commit 6404430.
|
Please resolve the conflict due to the deletion of the jenkinsfile |
|
it wasn't deleted :p |
# Conflicts: # Jenkinsfile
Kas-tle
approved these changes
Dec 19, 2023
Konicai
requested changes
Dec 19, 2023
...veice10/mc/protocol/packet/ingame/clientbound/scoreboard/ClientboundSetPlayerTeamPacket.java
Show resolved
Hide resolved
Konicai
reviewed
Dec 19, 2023
Konicai
approved these changes
Dec 19, 2023
|
Respectable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First PR in a series of changes broken down from my larger PR.