Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target Java 17 #773

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Target Java 17 #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,11 @@ jobs:
# See https://github.com/actions/checkout/commits
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac

- name: Set up JDK 1.8
- name: Set up JDK 17
# See https://github.com/actions/setup-java/commits
uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0
with:
java-version: 8
java-version: 17
distribution: temurin

- uses: s4u/maven-settings-action@60912582505985be4cc55d2b890eb32767f8de5f
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ jobs:
# See https://github.com/actions/checkout/commits
uses: actions/checkout@3df4ab11eba7bda6032a0b82a6bb43b11571feac

- name: Set up JDK 1.8
- name: Set up JDK 17
# See https://github.com/actions/setup-java/commits
uses: actions/setup-java@0ab4596768b603586c0de567f2430c30f5b0d2b0
with:
java-version: 8
java-version: 17
distribution: temurin

- name: Build with Maven
Expand Down
6 changes: 3 additions & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

<groupId>com.github.steveice10</groupId>
<artifactId>mcprotocollib</artifactId>
<version>1.20.4-1</version>
<version>1.20.4-2-SNAPSHOT</version>
<packaging>jar</packaging>

<name>MCProtocolLib</name>
Expand All @@ -20,8 +20,8 @@

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.source>1.8</maven.compiler.source>
<maven.compiler.target>1.8</maven.compiler.target>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<adventure.version>4.15.0-20231207.074016-23</adventure.version>
<!-- fixme: update to 4.15.0 when it releases -->
</properties>
Expand Down