Use built-in ResourceLocation type #811
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/data/game/item/component/AdventureModePredicate.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/data/game/item/component/ItemCodecHelper.java # protocol/src/main/java/org/geysermc/mcprotocollib/protocol/data/game/item/component/ToolData.java
|
I'm neutral on this and will delegate it to Bas or someone else to merge. I absolutely know that Keys are easier to use instead of loads of string splitting, but I did some testing and they do take up more memory, even with the |
# Conflicts: # protocol/src/test/java/org/geysermc/mcprotocollib/protocol/MinecraftProtocolTest.java
basaigh
requested changes
Jun 9, 2024
.../main/java/org/geysermc/mcprotocollib/protocol/data/game/entity/attribute/AttributeType.java
Outdated
Show resolved
Hide resolved
protocol/src/main/java/org/geysermc/mcprotocollib/protocol/codec/MinecraftCodecHelper.java
Outdated
Show resolved
Hide resolved
basaigh
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.