Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge-case where Texture#toString has a NullPointer because gson s… #838

Merged

Conversation

AlexProgrammerDE
Copy link
Contributor

…et a null metadata

Also changes NORMAL name to WIDE since that's the accurate name used inside the mc client.

…et a null metadata

Also changes NORMAL name to WIDE since that's the accurate name.
@AlexProgrammerDE
Copy link
Contributor Author

Mojang AuthLib has similar code:
image

@AlexProgrammerDE AlexProgrammerDE force-pushed the fix-edge-case-gameprofile branch from e8889d9 to a31c144 Compare July 18, 2024 09:06
@AlexProgrammerDE
Copy link
Contributor Author

Also fixes now #837

Copy link
Member

@onebeastchris onebeastchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@onebeastchris onebeastchris merged commit 05a699d into GeyserMC:master Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants