Fix/proxy protocol #862
Merged
Fix/proxy protocol #862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netty resolving is removed, if we can't resolve an address, netty can't either. The main difference is that netty may resolve addresses using an incorrect dns server/proxy unlike our code where we keep full control of the dns server and other things used to resolve addresses like users want us to resolve them.
|
nvm about the netty resolving stuff, the PR now uses the old code for haproxy and just cleans up a finally block |
onebeastchris
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix haproxy not having a working remote address
Netty resolving is removed, if we can't resolve an address, netty can't either. The main difference is that netty may resolve addresses using an incorrect dns server/proxy unlike our code where we keep full control of the dns server and other things used to resolve addresses like users want us to resolve them.