Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add macOS to the Github Action #159

Closed
Drjacky opened this issue Nov 25, 2023 · 4 comments
Closed

Add macOS to the Github Action #159

Drjacky opened this issue Nov 25, 2023 · 4 comments

Comments

@Drjacky
Copy link

Drjacky commented Nov 25, 2023

I see you have old versions for macOS:

url "https://github.com/hktalent/scan4all/releases/download/2.8.5/scan4all_2.8.5_macOS_amd64.zip"

Can you release the latest for macOS? or add Github Action to build for macOS as well?

@suzuki-shunsuke
Copy link

suzuki-shunsuke commented Nov 26, 2023

Recent Releases failed.

https://github.com/GhostTroops/scan4all/actions

image

https://github.com/GhostTroops/scan4all/actions/runs/6978505999/job/18990029445

Run goreleaser/goreleaser-action@v2
Downloading https://github.com/goreleaser/goreleaser/releases/download/v1.22.1/goreleaser_Darwin_all.tar.gz
Extracting GoReleaser
/usr/bin/tar xz -C /Users/runner/work/_temp/7cbb8c22-bb8d-479c-8f5d-005a7fa5ba1e -f /Users/runner/work/_temp/44aa81f3-29ee-46dc-80d5-9e58c0f6575b
GoReleaser latest installed successfully
2.8.9 tag found for commit '9a9e2d5b'
/Users/runner/hostedtoolcache/goreleaser-action/1.22.1/x64/goreleaser release -f .github/build/mac.yml --clean
  • starting release...
  • loading                                          path=.github/build/mac.yml
  • loading environment variables
    • using token from $GITHUB_TOKEN
  • getting and validating git state
    • git state                                      commit=9a9e2d5b40ccb49074bbef3b7826a096102cfca8 branch=HEAD current_tag=2.8.9 previous_tag=2.8.8 dirty=true
    • took: 2s
  ⨯ release failed after 1s                  error=git is in a dirty state
Please check in your pipeline what can be changing the following files:
 M tools/The-Hacker-Recipes

Learn more at https://goreleaser.com/errors/dirty

It seems the Git submodule tools/The-Hacker-Recipes was dirty.

  ⨯ release failed after 1s                  error=git is in a dirty state
Please check in your pipeline what can be changing the following files:
 M tools/The-Hacker-Recipes

Learn more at https://goreleaser.com/errors/dirty

https://goreleaser.com/errors/dirty

scan4all/.gitmodules

Lines 21 to 24 in 9a9e2d5

[submodule "tools/The-Hacker-Recipes"]
path = tools/The-Hacker-Recipes
url = https://github.com/ShutdownRepo/The-Hacker-Recipes.git
branch=master

https://github.com/ShutdownRepo/The-Hacker-Recipes

I'm not sure why the submodule was dirty.

@hktalent
Copy link
Collaborator

hktalent commented Dec 5, 2023

Thank you very much for finding and sharing these errors
Been busy recently
Have to wait some time

@hktalent
Copy link
Collaborator

myxxx23 pushed a commit that referenced this issue Dec 21, 2023
@Drjacky
Copy link
Author

Drjacky commented Dec 21, 2023

https://github.com/GhostTroops/scan4all/releases/

@hktalent
Could we also have aarch64? (for Apple Silicon)

Superoldman96 pushed a commit to Superoldman96/scan4all that referenced this issue Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants