Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doubled reply option in bdschael.dlg (cleanSoD.d) #36

Closed
Gitjas opened this issue Apr 12, 2019 · 1 comment
Closed

Doubled reply option in bdschael.dlg (cleanSoD.d) #36

Gitjas opened this issue Apr 12, 2019 · 1 comment

Comments

@Gitjas
Copy link

Gitjas commented Apr 12, 2019 •
edited
Loading

I haven't checked this in the game, but from the code I am sure this would be a doubled reply option and should be replaced with something else.
From cleanSoD.d (note that the first two reply options are doubled:

EXTEND_TOP BDSCHAEL 114
  IF ~OR(2) Dead("Dynaheir") Dead("Minsc") !Dead("Rasaad")~ THEN REPLY #260952 /* ~What do we have for options? ~ */ GOTO 115c
  IF ~OR(2) Dead("Dynaheir") Dead("Minsc") !Dead("Rasaad")~ THEN REPLY #260952 /* ~What do we have for options? ~ */ GOTO 115c
  IF ~OR(2) Dead("Dynaheir") Dead("Minsc") Dead("Rasaad")~ THEN REPLY #260952 /* ~What do we have for options? ~ */ GOTO 115d
END

Compared with the other states, I think this should be:

EXTEND_TOP BDSCHAEL 114
  IF ~!Dead("Dynaheir") !Dead("Minsc") Dead("Rasaad")~ THEN REPLY #260952 /* ~What do we have for options? ~ */ GOTO 115b
  IF ~OR(2) Dead("Dynaheir") Dead("Minsc") !Dead("Rasaad")~ THEN REPLY #260952 /* ~What do we have for options? ~ */ GOTO 115c
  IF ~OR(2) Dead("Dynaheir") Dead("Minsc") Dead("Rasaad")~ THEN REPLY #260952 /* ~What do we have for options? ~ */ GOTO 115d
END
@K4thos
Copy link
Collaborator

K4thos commented May 9, 2019

indeed, thanks!

@K4thos K4thos closed this as completed May 9, 2019
K4thos added a commit that referenced this issue May 11, 2019
@K4thos
issue #36, EET_End components
fdd30fa 
- EET_End no longer uses READLN action (tp2 now has 2 separate components)
- BG2 portraits assigned during BG2 transition (use EET_Tweaks components if you prefer consistent portraits)
- fixed duplicated dialog response (issue #36 on github)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@K4thos @Gitjas