refactor: Enhanced parser / redmine error-handling #152
+163
−48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m1sk9
changed the title
Lucky3028
approved these changes
Dec 21, 2024
Comment on lines
+32
to
+35
| if message.embeds.first().is_none() { | ||
| return; | ||
| }; | ||
| let embed = match parse_embed(message.embeds.first().unwrap()) { |
There was a problem hiding this comment.
Suggested change
| if message.embeds.first().is_none() { | |
| return; | |
| }; | |
| let embed = match parse_embed(message.embeds.first().unwrap()) { | |
| let Some(first_embed) = message.embeds.first else { return; }; | |
| let embed = match parse_embed(first_embed) { |
| } | ||
|
|
||
| fn parse_issue_number(title: &String) -> anyhow::Result<u16, ParseEnvIDsError> { | ||
| let re = match regex::Regex::new(r"#(\d+)") { |
There was a problem hiding this comment.
毎回Regexの構築が走って無駄なので https://doc.rust-lang.org/std/cell/struct.LazyCell.html で持ちたい
Comment on lines
+68
to
+71
| Some(caps) => match caps.get(1).unwrap().as_str().parse::<u16>() { | ||
| Ok(num) => Ok(num), | ||
| Err(why) => Err(ParseEnvIDsError::FailedToParseIssueNumber(why.to_string())), | ||
| }, |
There was a problem hiding this comment.
panic-safeにするなら気持ち的にはget(1).unwrap()をやめたくない？という気持ちがある。
そうではなくてもunwrapではなくexpectにしたいところ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SSIA