Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove const_transmute feature dependency #45

Merged
merged 6 commits into from
Jul 30, 2020
Merged

Remove const_transmute feature dependency #45

merged 6 commits into from
Jul 30, 2020

Conversation

RSSchermer
Copy link
Contributor

const_transmute seems to have been stabilized on current nightly, see rust-lang/rust#72920. This caused an unrecognized feature flag error when compiling against nightly.

`const_transmute` has been stabilized on current nightly, see rust-lang/rust#72920
@RalfJung
Copy link
Collaborator

The feature flag will still be needed when using offset_of! in a const fn, though. That should be documented at least.

@RSSchermer
Copy link
Contributor Author

Ah, I hadn't noticed yet that the flag essentially got replaced with const_fn_transmute. I added a test case for offset_of! inside a const fn that seemed to indicate the const_fn feature flag is also requirement. I've added a line to the readme.

@RalfJung
Copy link
Collaborator

This is great, thanks. :)
Can you run rustfmt on it so that CI passes?

@RSSchermer
Copy link
Contributor Author

Ah, sorry, silly oversight.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants