ALM - Project Migration #3972
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -54,7 +54,6 @@ | |
| <None Remove="DLLS\JiraRepositoryStd.dll" /> | ||
| <None Remove="DLLS\LibGit2Sharp.dll" /> | ||
| <None Remove="DLLS\OctaneInteractionStd.dll" /> | ||
| <None Remove="DLLS\SikuliStandardNet.dll" /> | ||
| <None Remove="DLLS\ZephyrEntStdSDK.dll" /> | ||
| <None Remove="DLLS\Zepyhr_Ent_Repository_Std.dll" /> | ||
|
|
@@ -122,9 +121,6 @@ | |
| <Content Include="DLLS\OctaneInteractionStd.dll"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </Content> | ||
| <Content Include="DLLS\SikuliStandardNet.dll"> | ||
| <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory> | ||
| </Content> | ||
|
|
@@ -361,13 +357,31 @@ | |
| <ItemGroup> | ||
| <Reference Include="ACL_Data_Contract"> | ||
| <HintPath>DLLS\ACL_Data_Contract.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="ACL_Utils_Server"> | ||
| <HintPath>DLLS\ACL_Utils_Server.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="AlmDataContractsStd"> | ||
| <HintPath>DLLS\AlmDataContractsStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="ALMFactory"> | ||
| <HintPath>DLLS\ALMFactory.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="AlmFactoryStd"> | ||
| <HintPath>DLLS\AlmFactoryStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="ALMRepository"> | ||
| <HintPath>DLLS\ALMRepository.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="AlmRepositoryStd"> | ||
| <HintPath>DLLS\AlmRepositoryStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="ALMRestClient"> | ||
| <HintPath>DLLS\ALMRestClient.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="ALMRestClientStd"> | ||
| <HintPath>DLLS\ALMRestClientStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="ALM_CommonStd"> | ||
| <HintPath>DLLS\ALM_CommonStd.dll</HintPath> | ||
| </Reference> | ||
|
|
@@ -380,33 +394,69 @@ | |
| <Reference Include="GingerHbaseFilter"> | ||
| <HintPath>DLLS\GingerHbaseFilter.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="Interop.TDAPIOLELib"> | ||
| <HintPath>DLLS\Interop.TDAPIOLELib.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="JiraRepositoryStd"> | ||
| <HintPath>DLLS\JiraRepositoryStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="LibGit2Sharp"> | ||
| <HintPath>DLLS\LibGit2Sharp.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="ObjectsUtils"> | ||
| <HintPath>DLLS\ObjectsUtils.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="OctaneRepositoryStd"> | ||
| <HintPath>DLLS\OctaneRepositoryStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="OctaneSdkStandard"> | ||
| <HintPath>DLLS\OctaneSdkStandard.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="OctaneStdSDK"> | ||
| <HintPath>DLLS\OctaneStdSDK.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="Octane_Repository"> | ||
| <HintPath>DLLS\Octane_Repository.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="protobuf-net"> | ||
| <HintPath>DLLS\protobuf-net.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="QcRepository"> | ||
| <HintPath>DLLS\QcRepository.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="QCRestClientStd"> | ||
| <HintPath>DLLS\QCRestClientStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="QCRest_Repository"> | ||
| <HintPath>DLLS\QCRest_Repository.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="QTestAPI"> | ||
| <HintPath>DLLS\QTestAPI.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="QTestAPIStd"> | ||
| <HintPath>DLLS\QTestAPIStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="QTestRepository"> | ||
| <HintPath>DLLS\QTestRepository.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="RQMExport"> | ||
| <HintPath>DLLS\RQMExport.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="RQMExportStd"> | ||
| <HintPath>DLLS\RQMExportStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="RQM_Repository"> | ||
| <HintPath>DLLS\RQM_Repository.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="RQM_RepositoryStd"> | ||
| <HintPath>DLLS\RQM_RepositoryStd.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="SikuliStandardNet"> | ||
| <HintPath>DLLS\SikuliStandardNet.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="SubAppUtils"> | ||
| <HintPath>DLLS\SubAppUtils.dll</HintPath> | ||
| </Reference> | ||
| <Reference Include="ZephyrEntStdSDK"> | ||
| <HintPath>DLLS\ZephyrEntStdSDK.dll</HintPath> | ||
| </Reference> | ||
|
|
||
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
|
|
@@ -290,6 +290,22 @@ private object UpdateALMType(eALMType almType) | |||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| case eALMType.Azure: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| almCore = new AzureDevOpsCore(); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| break; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| case eALMType.Qtest: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| almCore = new QtestCore(); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| break; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| case eALMType.QC: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| if (CurrentAlmConfigurations.UseRest) | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| almCore = new QCRestAPICore(); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| else | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| { | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| almCore = new QCCore(); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| } | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| break; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| case eALMType.RQM: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| almCore = new RQMCore(); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| break; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
Comment on lines
+293
to
+308
There was a problem hiding this comment. 🛠️ Refactor suggestion Consider implementing a factory pattern for ALM core instantiation. The switch statement for ALM type handling is growing and could benefit from a more maintainable design pattern. Consider extracting this logic into a factory class to improve maintainability and testability. Here's a suggested implementation: public interface IALMCoreFactory
{
ALMCore CreateALMCore(eALMType almType, ALMConfig config);
}
public class ALMCoreFactory : IALMCoreFactory
{
public ALMCore CreateALMCore(eALMType almType, ALMConfig config)
{
if (config == null)
{
Reporter.ToLog(eLogLevel.ERROR, $"Missing configuration for {almType}");
return null;
}
ALMCore core = almType switch
{
eALMType.Qtest => new QtestCore(),
eALMType.QC when config.UseRest => new QCRestAPICore(),
eALMType.QC => new QCCore(),
eALMType.RQM => new RQMCore(),
_ => null
};
if (core == null)
{
Reporter.ToLog(eLogLevel.ERROR, $"Failed to initialize {almType} core");
}
return core;
}
}Then update the -private object UpdateALMType(eALMType almType)
+private object UpdateALMType(eALMType almType, IALMCoreFactory factory = null)
{
- ALMCore almCore = null;
ALMConfig CurrentAlmConfigurations = ALMCore.GetCurrentAlmConfig(almType);
ALMCore.DefaultAlmConfig = CurrentAlmConfigurations;
- //Set ALMRepo
- switch (almType)
- {
- case eALMType.Qtest:
- almCore = new QtestCore();
- break;
- // ... other cases
- }
+
+ factory ??= new ALMCoreFactory();
+ ALMCore almCore = factory.CreateALMCore(almType, CurrentAlmConfigurations);
return almCore;
}Ensure consistent error handling across ALM implementations. The new ALM type implementations should follow the same error handling patterns as existing ones. A few observations:
Consider applying this more robust implementation: case eALMType.Qtest:
- almCore = new QtestCore();
+ if (CurrentAlmConfigurations != null)
+ {
+ almCore = new QtestCore();
+ if (almCore == null)
+ {
+ Reporter.ToLog(eLogLevel.ERROR, $"Failed to initialize QtestCore");
+ }
+ }
+ else
+ {
+ Reporter.ToLog(eLogLevel.ERROR, $"Missing Qtest configuration");
+ }
break;
case eALMType.QC:
if (CurrentAlmConfigurations.UseRest)
{
almCore = new QCRestAPICore();
+ if (almCore == null)
+ {
+ Reporter.ToLog(eLogLevel.ERROR, $"Failed to initialize QCRestAPICore");
+ }
}
else
{
almCore = new QCCore();
+ if (almCore == null)
+ {
+ Reporter.ToLog(eLogLevel.ERROR, $"Failed to initialize QCCore");
+ }
}
break;
case eALMType.RQM:
- almCore = new RQMCore();
+ if (CurrentAlmConfigurations != null)
+ {
+ almCore = new RQMCore();
+ if (almCore == null)
+ {
+ Reporter.ToLog(eLogLevel.ERROR, $"Failed to initialize RQMCore");
+ }
+ }
+ else
+ {
+ Reporter.ToLog(eLogLevel.ERROR, $"Missing RQM configuration");
+ }
break;📝 Committable suggestion
Suggested change
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| default: | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Reporter.ToLog(eLogLevel.ERROR, $"Invalid ALM Type - {almType}"); | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| break; | ||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
|
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add try-finally block for cursor management
The cursor should be reset even if an exception occurs during the RQM operation. Consider wrapping the code in a try-finally block.
Here's the suggested fix:
📝 Committable suggestion