Bug fix/Hbase Sql one value support

[GokulBothe99]

Thank you for your contribution.
Before submitting this PR, please make sure:

• PR description and commit message should describe the changes done in this PR
• Verify the PR is pointing to correct branch i.e. Release or Beta branch if the code fix is for specific release , else point it to master
• Latest Code from master or specific release branch is merged to your branch
• No unwanted\commented\junk code is included
• No new warning upon build solution
• Code Summary\Comments are added to my code which explains what my code is doing
• Existing unit test cases are passed
• New Unit tests are added for your development
• Sanity Tests are successfully executed for New and Existing Functionality
• Verify that changes are compatible with all relevant browsers and platforms.
• After creating pull request there should not be any conflicts
• Resolve all Codacy comments
• Builds and checks are passed before PR is sent for review
• Resolve code review comments
• Update the Help Library document to match any feature changes

Summary by CodeRabbit

• New Features

  • Enhanced UI interactions for database operations, improving responsiveness and clarity.
  • Improved visibility settings for UI elements based on selected database operation types.

• Bug Fixes

  • Streamlined error handling and control flow during database operations.
  • Ensured combo box selections clear or populate related fields appropriately.

• Chores

  • Improved encapsulation and organization of Hbase connection handling.

[coderabbitai]

Walkthrough

The changes in this pull request involve modifications to the ValidationDBPage.xaml.cs and DatabaseOperations.cs files, focusing on enhancing database operation handling and UI interactions. In ValidationDBPage.xaml.cs, asynchronous methods for dropdown events have been streamlined, and UI visibility logic has been refined based on user selections. In DatabaseOperations.cs, methods for retrieving table and column data have been improved for clarity and efficiency, including better encapsulation of Hbase client creation.

Changes

File Path	Change Summary
Ginger/Ginger/Actions/ActionEditPages/ValidationDBPage.xaml.cs	Updated TablesComboBox_DropDownOpened to simplify error handling, adjusted ColumnComboBox_DropDownOpened for clearing data, and refined UI visibility logic in SetVisibleControlsForAction.
Ginger/GingerCoreNET/Database/DatabaseOperations.cs	Modified GetTablesListAsync and GetTablesColumns to utilize a new private method CreateHbaseClient for better encapsulation and connection handling.

Possibly related PRs

• Bug fix/Hbase where cluse working #3999: The changes in the GingerHbase class related to SQL query processing and error management may connect with the main PR's focus on database operations, particularly if the ValidationDBPage.xaml.cs interacts with Hbase in any way.
• Hbase Simple SQL One Value fix #4016: Similar to Bug fix/Hbase where cluse working #3999, this PR also modifies the GingerHbase class, enhancing its functionality for database interactions, which could relate to the main PR's updates on database handling in the UI.

Suggested reviewers

• Maheshkale447

🐇 In the garden where the code does grow,
Changes sprout, like carrots in a row.
With dropdowns clear and logic bright,
Our UI dances, a joyful sight!
Database whispers, connections refined,
A smoother journey for all of humankind! 🌼

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 8b8a4eb and 31b9c38.

📒 Files selected for processing (1)

• Ginger/GingerCoreNET/Database/DatabaseOperations.cs (3 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• Ginger/GingerCoreNET/Database/DatabaseOperations.cs

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Outside diff range and nitpick comments (2)

Ginger/GingerCoreNET/Database/DatabaseOperations.cs (1)

533-537: LGTM! Consider consolidating connection parameters.

The initialization of GingerHbase is consistent with other NoSQL handlers, but consider consolidating the connection parameters into a configuration object for better maintainability.

-GingerHbase ghbase = new GingerHbase(Database.TNS, Database.User, Database.Pass)
-{
-    Db = Database
-};
+var config = new HbaseConfig 
+{
+    TNS = Database.TNS,
+    User = Database.User,
+    Pass = Database.Pass,
+    Db = Database
+};
+GingerHbase ghbase = new GingerHbase(config);

Ginger/Ginger/Actions/ActionEditPages/ValidationDBPage.xaml.cs (1)

405-425: LGTM! Consider enhancing error handling and user feedback.

The async/await implementation and UI thread handling are correct. However, consider these improvements:

1. Add user-friendly error messages for common database connection issues
2. Show loading indicator in the ComboBox during table fetch

 await Task.Run(async () =>
 {
     try
     {
+        Dispatcher.Invoke(() => TablesComboBox.Items.Add("Loading..."));
         List<string> tables = await db.DatabaseOperations.GetTablesListAsync(KeySpace);
         if (tables != null)
         {
             Dispatcher.Invoke(() =>
             {
+                TablesComboBox.Items.Clear();
                 foreach (string s in tables)
                 {
                     TablesComboBox.Items.Add(s);
                 }
             });
         }
         Reporter.HideStatusMessage();
     }
     catch (Exception ex)
     {
         Reporter.ToLog(eLogLevel.ERROR, $"{db.DatabaseOperations} failed to get tables", ex);
+        Dispatcher.Invoke(() =>
+        {
+            TablesComboBox.Items.Clear();
+            TablesComboBox.Items.Add("Error loading tables. Please try again.");
+            Reporter.ToUser(eUserMsgKey.DatabaseConnectionError, ex.Message);
+        });
     }
 });

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between 50f71c2 and 8b8a4eb.

📒 Files selected for processing (2)

• Ginger/Ginger/Actions/ActionEditPages/ValidationDBPage.xaml.cs (1 hunks)
• Ginger/GingerCoreNET/Database/DatabaseOperations.cs (2 hunks)