Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qobuz (and probably tidal) login broken #5

Closed
matthew-salerno opened this issue Sep 26, 2022 · 1 comment · Fixed by #7
Closed

Qobuz (and probably tidal) login broken #5

matthew-salerno opened this issue Sep 26, 2022 · 1 comment · Fixed by #7
Assignees
Labels
bug Something isn't working

Comments

@matthew-salerno
Copy link

matthew-salerno commented Sep 26, 2022

Commit 12c7cc2 breaks Qobuz (and probably Tidal) support by changing the QOBUZ_PASSWORD, QOBUZ_USERNAME, etc, placeholders. Sed no longer finds them and you're left with the default (non working) login credentials. This commit may have broken other things as well, I haven't looked through it too much and don't have the environment to be debugging docker projects.
As a side note, this project has made deploying upmpd actually easy, I was really concerned I'd have to build it myself on all my different platforms but thanks to this container I don't have to. It's been a huge help, thanks!

@GioF71
Copy link
Owner

GioF71 commented Sep 26, 2022

Hello, yes I will have a look.
I replaced the configuration file and overlooked those side effects. I don't have an active qobuz subscription currently.
Does qobuz still work for you on my container before this change?
Thanks!

@GioF71 GioF71 self-assigned this Sep 26, 2022
GioF71 added a commit that referenced this issue Sep 26, 2022
@GioF71 GioF71 linked a pull request Sep 26, 2022 that will close this issue
@GioF71 GioF71 closed this as completed in #7 Sep 26, 2022
GioF71 added a commit that referenced this issue Sep 26, 2022
@GioF71 GioF71 added the bug Something isn't working label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants