Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataframes v0.11 is out #1065

Closed
tlnagy opened this issue Dec 6, 2017 · 6 comments
Closed

Dataframes v0.11 is out #1065

tlnagy opened this issue Dec 6, 2017 · 6 comments

Comments

@tlnagy
Copy link
Member

tlnagy commented Dec 6, 2017

This is a pretty big change and we need make sure Gadfly works with it. I believe the main hangup right now is that RDatasets (which we use for tests) doesn't work with v0.11 until JuliaStats/RDatasets.jl#48 merges.

Then we'll need to drop DataArrays from REQUIRE and peg the minimum version of DataFrames at v0.11 and fix any problems.

@va-andrew
Copy link

Plus one for this issue. We had to remove Gadfly from our workflow until it can coexist with the newer versions of DataFrames (it currently forces a downgrade when used with Pkg).

@tlnagy
Copy link
Member Author

tlnagy commented Jan 11, 2018

Looks like JuliaStats/RDatasets.jl#48 is basically ready so we can bump our requirements once it's merged and a new release is tagged.

tlnagy added a commit to tlnagy/Gadfly.jl that referenced this issue Jan 11, 2018
i haven't been able to fix everything due to slight inconsistencies
between PooledDataArrays and CategoricalArrays behavior. See
JuliaData/CategoricalArrays.jl#117 for
details. Working towards a fix for GiovineItalia#1065
@tlnagy
Copy link
Member Author

tlnagy commented Feb 1, 2018

The work has moved to #1090

@andreasnoack
Copy link
Contributor

I think this can be closed. Eventually, we might want to remove DataArrays as a dependency but it is not required.

@bjarthur
Copy link
Member

bjarthur commented Apr 5, 2018

happy to close this. you've done great work @andreasnoack ! thanks for taking on this important issue.

re. DataArrays... is it or is it not a dependency? should be removed now from REQUIRE if not.

@bjarthur bjarthur closed this as completed Apr 5, 2018
@andreasnoack
Copy link
Contributor

There is still code left to handle DataArrays if passed to Gadfly but I don't think we use them for anything so I suspect that it can be removed. I might take a look at that later today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants