Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geom.blank #1345

Merged
merged 1 commit into from
Nov 17, 2019
Merged

Geom.blank #1345

merged 1 commit into from
Nov 17, 2019

Conversation

Mattriks
Copy link
Member

@Mattriks Mattriks commented Nov 12, 2019

  • I've updated the documentation to reflect these changes
  • I've added an entry to NEWS.md
  • I've added and/or updated the unit tests
  • I've run the regression tests
  • I've built the docs and confirmed these changes don't cause new errors

This PR

Example

p1 = plot(x=[0,10], y=[0,1], Geom.blank)
p2 = plot()
p3 = push!(plot(), layer(x=1:5, y=rand(5), Geom.point))
hstack(p1, p2, p3)

geom_blank

@bjarthur
Copy link
Member

docs are timing out, despite the recent PR adding travis_wait.

@Mattriks
Copy link
Member Author

Mattriks commented Nov 16, 2019

This PR is running travis with the old travis.yml (before #1343). I'll wait til you merge #1347 and #1348, then rebase.

@codecov-io
Copy link

Codecov Report

Merging #1345 into master will decrease coverage by 0.11%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1345      +/-   ##
==========================================
- Coverage   90.15%   90.03%   -0.12%     
==========================================
  Files          36       37       +1     
  Lines        3940     3944       +4     
==========================================
- Hits         3552     3551       -1     
- Misses        388      393       +5
Impacted Files Coverage Δ
src/geometry.jl 75% <ø> (ø) ⬆️
src/Gadfly.jl 77.38% <0%> (-0.2%) ⬇️
src/geom/blank.jl 0% <0%> (ø)
src/aesthetics.jl 81.03% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2816ba5...eed6efb. Read the comment docs.

@Mattriks
Copy link
Member Author

Done.

@bjarthur bjarthur merged commit 248f308 into GiovineItalia:master Nov 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zero-argument function definition missing for plot()
3 participants