'isomorphic-fetch' breaks react-native projects

[alexfoxy]

I can't use this api within a react native project as it conflicts with react natives own fetch.

To fix I have uncommented require('isomorphic-fetch'); from line 14 in RequestHandler.js

Is there a more solid fix?

[cosmocochrane1]

@alexfoxy i'll check it out!

[giannif]

@alexfoxy @cosmocochrane1
We do need some sort of polyfill if we're going to support older browsers that don't have fetch. Perhaps there's a way to not pollute the global scope.

There's this: https://www.npmjs.com/package/unfetch which is much smaller than the isomorphic-fetch lib I added way back when to support server side rendering, and it supports not polluting the global scope: https://www.npmjs.com/package/unfetch#usage

[rodrigobdz]

@alexfoxy @giannif could you check if the approach in #26 works for you?

[rodrigobdz]

I think this was fixed in #26. Close?

[cosmocochrane1]

@rodrigobdz I'm gonna confirm - have you tried to run it with a reactnative proj yet?

[rodrigobdz]

I am using the fix in a React Native project I am working on. I will create a new one to test in isolation.

_{Sent with GitHawk}

[rodrigobdz]

@cosmocochrane1 It's working for me. Feel free to try it out. I made a MCVE which you can find here.

There are two branches:

• master is running against giphy-js-sdk-core v1.0.3.
• giphy-js-sdk-core-v1.0.5 is running against giphy-js-sdk-core v1.0.5.

[cosmocochrane1]

@rodrigobdz radddd thanks taking a look now