Skip to content

Commit

Permalink
chore(tests): fix test failure caused by vcrpy
Browse files Browse the repository at this point in the history
vcrpy does not use urllib3 correctly. Pin urllib3 until
kevin1024/vcrpy#688 is fixed.

Needed a hack in the "Install dependencies" step to work around a build
failure on Windows: for some reason the Windows builder still had urllib
2.0.2 installed. Could not reproduce this in my Windows VM so I suspect
there is a bug in the way the setup-python GitHub action works.
  • Loading branch information
agateau-gg committed May 5, 2023
1 parent de0a63f commit c652798
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,8 @@ jobs:
python -m pip install --upgrade pip
python -m pip install --upgrade pipenv==2022.10.4
pipenv install --system --dev
# Hack: workaround urllib3 still being installed on windows-2022 builder
pip install --force-reinstall 'urllib3<2'
- name: Install Windows dev dependencies
if: matrix.os == 'windows-2022'
run: |
Expand Down
1 change: 1 addition & 0 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,6 @@ types-oauthlib = "*"
typing-extensions = "*"

vcrpy = "*"
urllib3 = "<2" # pin until https://github.com/kevin1024/vcrpy/issues/688 is fixed
pyfakefs = ">=5.2.0"
scriv = { version = "*", extras = ["toml"] }

0 comments on commit c652798

Please sign in to comment.