-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(with-incident-details): Ensure the token has the correct scope #1015
base: main
Are you sure you want to change the base?
fix(with-incident-details): Ensure the token has the correct scope #1015
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1015 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 181 181
Lines 7704 7717 +13
=======================================
+ Hits 7091 7103 +12
- Misses 613 614 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
265403f
to
b789dd7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems alright with me! 🙂 (though it's my very first review here)
(Don't forget to revert pdm update once GitGuardian/py-gitguardian#126 is released)
b789dd7
to
6ac5fc2
Compare
6ac5fc2
to
6462217
Compare
Context
ggshield 1.32.0 can now return the details of an incident when a scan is run with the --with-incident-details option. For this feature to work, the token used to authenticate with the API must have the 'incidents:read' scope. This is currently not documented and if the token does not have the required scope, the flag will be silently ignored.
What has been done
Ensure the token has the required scope before running a command with
--with-incident-details
flag. This MR goes with GitGuardian/py-gitguardian#126PR check list
skip-changelog
label has been added to the PR.