Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding a warning message about Python 3.8 #1019

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

sevbch
Copy link

@sevbch sevbch commented Nov 25, 2024

Python 3.8 is no longer supported by the Python Software Foundation. Thus, GGShield will soon require Python 3.9 and above to run.

In this PR we add a deprecation warning message to warn Python 3.8 users about future deprecation.

Output example:

$ ggshield api-status
API URL: https://dashboard.gitguardian.com
Status: healthy
App version: v2.119.0
Secrets engine version: 2.126.0

Instance source: default
API key source: user config

Warning: Python 3.8 is no longer supported by the Python Software Foundation. GGShield will soon require Python 3.9 or above to run.

@sevbch sevbch self-assigned this Nov 25, 2024
@sevbch sevbch requested a review from a team as a code owner November 25, 2024 10:47
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.04%. Comparing base (035d74b) to head (ae62e54).
Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1019   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files         181      181           
  Lines        7717     7719    +2     
=======================================
+ Hits         7103     7105    +2     
  Misses        614      614           
Flag Coverage Δ
unittests 92.04% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sevbch sevbch marked this pull request as draft November 25, 2024 13:30
@sevbch sevbch force-pushed the severine/deprecation-message-python-3.8 branch 5 times, most recently from d5ffb73 to 01d5913 Compare November 25, 2024 15:54
README.md Show resolved Hide resolved
@sevbch sevbch force-pushed the severine/deprecation-message-python-3.8 branch from 01d5913 to 275498a Compare November 25, 2024 15:59
@sevbch sevbch marked this pull request as ready for review November 25, 2024 17:40
@sevbch sevbch assigned salome-voltz and unassigned salome-voltz Nov 26, 2024
Copy link
Collaborator

@agateau-gg agateau-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now 👍🏻.

That was a bit more involved than I expected 😞.

@agateau-gg agateau-gg merged commit 4cc9946 into main Nov 26, 2024
33 checks passed
@agateau-gg agateau-gg deleted the severine/deprecation-message-python-3.8 branch November 26, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants