-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding a warning message about Python 3.8 #1019
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
=======================================
Coverage 92.04% 92.04%
=======================================
Files 181 181
Lines 7717 7719 +2
=======================================
+ Hits 7103 7105 +2
Misses 614 614
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
d5ffb73
to
01d5913
Compare
01d5913
to
275498a
Compare
changelog.d/20241125_113845_severine.bonnechere_scrt_5123_before_next_ggshield_release.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now 👍🏻.
That was a bit more involved than I expected 😞.
Python 3.8 is no longer supported by the Python Software Foundation. Thus, GGShield will soon require Python 3.9 and above to run.
In this PR we add a deprecation warning message to warn Python 3.8 users about future deprecation.
Output example: