-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing dependency #1043
Add missing dependency #1043
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1043 +/- ##
=======================================
Coverage 92.09% 92.09%
=======================================
Files 181 181
Lines 7756 7756
=======================================
Hits 7143 7143
Misses 613 613
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Make the package bundle a copy of libcrypt.so.1 because our bundled Python still uses this version, but some distributions now ship libcrypt.so.2.
Our RPM only depends on git-core, so install only that.
6af82c5
to
5d39600
Compare
This way we get security upgrades.
7db2dd0
to
7f68d32
Compare
strategy: | ||
fail-fast: false | ||
matrix: | ||
include: | ||
- os: ubuntu-22.04 | ||
# When building on Linux we use a container to build using an old enough version | ||
container: rockylinux/rockylinux:8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I recall correctly, we initially fixed the minor version of rockylinux to 8.8 for python version consideration. Maybe it would be safer to pin a version here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is the 8.8 images do not receive security upgrades (See Rocky Linux Docker page), so it's less work for the CI to start from the latest 8 to build. The smoke tests run at the end still use 8.8 so it can't break without us noticing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All right, all good then, thanks for the clarification !
Context
The Python interpreter we bundle in our RPM package depends on libcrypt.so.1, but some distributions do not ship it anymore. This is why ggshield fails when it's installed using its RPM package on Red Hat Enterprise Linux 9 (See #1036).
What has been done
Validation
ggshield --version
→ with the released version it fails, with the version from the CI it worksPR check list
skip-changelog
label has been added to the PR.