Fix fails on pull-requests from forks #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agateau-gg
changed the title
pierrelalanne
approved these changes
Feb 22, 2023
There was a problem hiding this comment.
Looks good to me !
Interestingly enough, GitHub seems to group the checks from both PRs here and we can see that it behaves as expected.
Do not run steps which require the GITGUARDIAN_API_KEY variable. These steps always fail because the variable is not available for pull-requests coming from forks. Fixes #374
agateau-gg
force-pushed
the
agateau/fix-fails-from-forks
branch
from
0696aa0
to
6ba04c5
Compare
This was referenced Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not run steps which require the GITGUARDIAN_API_KEY variable. These steps always fail because the variable is not available for pull-requests coming from forks.
Fixes #374
Testing
This PR merges a branch from the GitGuardian/ggshield repository, so all steps should run.
PR #484 merges the same branch, but from my fork of the repository, and this time not all steps run.
Update: looks like GitHub is confused and now shows the same results as for this PR. You can look at this previous run to see skipped jobs (the GitHub action test jobs) and steps (the functional tests inside the build jobs). There is also this run of the performance benchmark which is skipped too.