[11.14] Group milestones API: able to call GitLab API with addtional parameters updated_before and updated_after #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Groups Milestones (Gitlab\Tests\Api\GroupsMilestones) ✔ Should get all milestones with parameter one iids value ✔ Should get all milestones with parameter two iids values ✔ Should get all milestones with parameter state with active ✔ Should get all milestones with parameter state with closed ✔ Should get all milestones with parameter search ✔ Should get all milestones with parameter updated before ✔ Should get all milestones with parameter updated after
wenchaoxue
changed the title
GrahamCampbell
changed the title
GrahamCampbell
requested changes
Dec 3, 2023
src/Api/GroupsMilestones.php
Outdated
| * @var string $search Return only milestones with a title or description matching the provided string | ||
| * @var string $updated_before Return only milestones updated before the given datetime | ||
| * Expected in ISO 8601 format (2019-03-15T08:00:00Z). Introduced in GitLab 15.10 | ||
| * @var string $updated_after Return only milestones updated after the given datetime |
There was a problem hiding this comment.
Please take DateTimeInterface here rather than a string, just like in Groups::issues.
There was a problem hiding this comment.
Sorry for the delay, finally I have time to fix it - here
Use DateTimeInterface is much better than string.
There was a problem hiding this comment.
@GrahamCampbell the PR is ready to be reviewed in case you haven't received this notice before. Thanks for reviewing it.
…ed_before update unit tests
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
List group milestones new parameters