Fix dependencies and permissions in AAR extraction #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmasa
force-pushed
the
aar-extract-improvements
branch
from
a5a3ed5 to
427d844
Compare
fmasa
force-pushed
the
aar-extract-improvements
branch
from
427d844 to
712380e
Compare
nbransby
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10
This forces 660 (-rw-rw---) permissions for extracted JAR so repeated extraction does not fail. Previously some JARs were extracted as read-only and these could not be rewritten.
I also changed the way list of AAR files is sourced. Now both
extractClassesandcopyAarsuseaarconfigurations so the list of dependencies is known beforehand and first./gradlew buildno longer fails. I also merged the separate tasks for each dependency to theextractClasses.