Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

add osx-temperature-sensor as optional dependency (fix #402) #415

Merged
merged 4 commits into from
Feb 1, 2019

Conversation

syxanash
Copy link
Contributor

@syxanash syxanash commented Jan 31, 2019

it resolves #402

Check out known issues on systeminformation repo.

@GitSquared
Copy link
Owner

Manually adding the dependency in a script only fixes the issue if you're running from source - electron-builder repackages all dependencies on build.

I reverted your second commit and moved osx-temperature-sensor to an optional dependency, so it should be bundled and installed on macOS systems and silently ignored on other platforms.

Nice job finding the corresponding known issue in systeminformation.

P.S:
image

@GitSquared GitSquared changed the title add osx-temperature-sensor as dependency add osx-temperature-sensor as optional dependency (fix #402) Feb 1, 2019
@GitSquared GitSquared merged commit 2b03097 into GitSquared:master Feb 1, 2019
@syxanash
Copy link
Contributor Author

syxanash commented Feb 1, 2019

awesome thanks for the tip about optionalDependencies 👍
Glad you like my gitron man, made my day!!!

@syxanash syxanash deleted the osx-temperature-fix branch February 1, 2019 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cpu tmep on macOS
2 participants