This repository has been archived by the owner on Feb 12, 2023. It is now read-only.
(#37) Add CustomRawUrlProvider to enable arbitrary content URLs #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I will review as soon as I am back (thursday or friday). |
| [TestFixture] | ||
| public class TheInitialization | ||
| { | ||
| [TestCase] |
There was a problem hiding this comment.
You could just create a single Test method and use test cases like this:
[TestCase("http://example.com/repo", true)]
[TestCase("gopher://example.com/repo", false)]
public void CorrectlyValidatesForUrls(string url, bool expectedValue)
{
// Test code here
}
There was a problem hiding this comment.
It seemed like tests for other providers used explicit test case names for the positive and negative results so I kept that pattern. Let me know if you still like it changed.
There was a problem hiding this comment.
That was a mistake made by us. Please make the change, I will change the other tests after that.
|
From what I can see, this PR looks really good. I will verify with VS once I get home. |
A new CustomRawUrlProvider is added that acts as the final IProvider candidate. This provider interprets the TargetUrl parameter (`-u`) as the url to use for the RawGitUrl property of the provider. This enables supporting custom github/bitbucket content proxies as well as opens up an easy way to support conforming alternative git services without having to write a new IProvider implementation for each one.
|
|
||
| GitLink.exe c:\source\catel -u https://raw.githubusercontent.com/catel/catel | ||
|
|
||
| The custom url will be used to fill in the following pattern `{customUrl}/{revision}/{raltiveFilePath}` when generating the source mapping. |
There was a problem hiding this comment.
raltiveFilePath => relativeFilePath
GeertvanHorrik
added a commit
that referenced
this pull request
Nov 12, 2015
(#37) Add CustomRawUrlProvider to enable arbitrary content URLs
|
Very nice, this is much appreciated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature in this PR can be used to tackle a number of open scenarios:
{rootUrl}/{revision}/{relativeFilePath}- as encoded in the inner workings of Linker.cs)The solution is to introduce a fallback provider that uses the
TargetUrlparameter as the{rootUrl}in that raw content access pattern. The usage would be as follows: