Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(GH-90) Relax restriction of one label per issue #102

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

robertlyson
Copy link

This PR addresses #90.

@ghuntley
Copy link

ghuntley commented Oct 5, 2017

@robertlyson omg it's you again. Love your work.

image

Was about to tweet out a bounty but no need now. Get this merged in and I'll buy you a beer.

@ghuntley
Copy link

ghuntley commented Oct 9, 2017

Alright gep13 has asked me to review. Busy tonight though - might be a couple days. Thank-you @robertlyson. One less thing to do/thing that was blocking the release of reactiveui/reactiveui v8!

@RichiCoder1
Copy link

I will chip in on that beer once this gets merged!

Previously GitReleaseManager wasn't able to generate release note for issues with multiple labels.
With this change it's become possible, but additional configuration flag needs to be set.
@RLittlesII
Copy link

@gep13 I downloaded the source from AppVeyor. Initial test was good I added issue-labels-many: true to my GitReleaseManager.yml and it created a release not problems! Everything in the release seemed to be in order.

@RLittlesII
Copy link

@gep13 base on the provided gist that was generated from using this PR's source, my expectations would have been the following.

  • issue-labels-alias should be respected when creating headers and plurals
  • 1702 should have shown under both ReactiveUI Core and Bugs label
  • 1650 should have shown under both Windows Forms and Bugs

Other than those things, I am not sure I had many expectations. Sight unseen (not looking at the issue, or the PR code), these would have been my expectations from this feature. If any of this extends past what the feature is providing, I am honestly just happy to have GRM succeed in generating notes with multiple labels.

@RLittlesII
Copy link

@gep13 Status Check? How can I help move these chains?

@GeertvanHorrik
Copy link
Contributor

@gep13 I've code reviewed this PR and I think it looks good. Time to merge?

@SimonCropp
Copy link
Contributor

@gep13 seems like this was a good idea? need any help reviving it?

@gep13
Copy link
Member

gep13 commented Jan 28, 2020

@SimonCropp said...
seems like this was a good idea? need any help reviving it?

I am certainly not going to say no 😄

I have been internally debating this for a while, as I think there is more to it, once we open up the ability to have more than one label, i.e. grouping of issues/pr's into section based on a label, ordering issues/pr's based on another label, and I have never settled on a "good" way to handle all these things.

Perhaps I have been over-complicating the issue, and "all" that is required is support for having multiple labels, and having an issue/pr appear in two sections of the generated release notes.

Would be happy for you to take a spin at implementing this. There has been a lot of work done on the code base since this PR was raised, so could be that it would be better to start again.

@Cheesebaron
Copy link
Collaborator

I would love for something like @gep13 mentions be implemented:

"all" that is required is support for having multiple labels, and having an issue/pr appear in two sections of the generated release notes

At least that would be a very good start. Then we could think about improving that functionality.

@davidzwa
Copy link

I just wanted to let you know that I'm planning to work on this, if you'll allow me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants