Sha is appended to AssemblyInformationalVersionAttribute when gitversion.json modified before CoreGenerateAssemblyInfo MSBuild task

[RobSmyth]

Prerequisites

• I have written a descriptive issue title
• I have searched issues to ensure it has not already been reported

GitVersion package

GitVersion.MsBuild

GitVersion version

6.0.0

Operating system

Windows

What are you seeing?

Using GitVersion.MSBuild, I have inserted a task after GenerateGitVersionInformation task and before CoreGenerateAssemblyInfo task that modifies the generated gitversion.json file (only). The generated AssemblyInformationalVersion contains the modified InforationVersion in the json file but appends the full Sha.

After doing this, the gitversion.json file in the obj folder contains:

"InformationalVersion": "1.2.3+Informational",

This is correct. I have inserted this text for testing.

GitVersionInformation.g.cs contains:

public const string InformationalVersion = "1.2.3+Informational";

Also good.

But the compiled dll assembly info version viewed in explorer (and my tests) is:

1.2.3+Informational.f9c0808df67d3e6b21c0c4c27051b3befe469f69

Is this expected behaviour? If so, can I stop it appending?

What is expected?

The AssemblyInformationalVersion to use the InformationalVersion property from the generated files and not a sha.

Steps to Reproduce

Difficult as I've gone to some trouble creating a task that runs a script to modify gitversion.json and it is not complete.

My task runs with this setup:

 <PropertyGroup>
    <MyTestBeforeTargets Condition=" '$(MyTestBeforeTargets)' == '' ">
      GetVersion;
      CoreCompile;
      GetAssemblyVersion;
      GenerateNuspec;
      _GetOutputItemsFromPack;
      EnsureWixToolsetInstalled;
      UpdateAssemblyInfo;
      CoreGenerateAssemblyInfo
    </MyTestBeforeTargets>
    <MyTestDependOnTargets>GenerateGitVersionInformation</MyTestDependOnTargets>
    <MyTestScriptPath Condition=" '$(MyTestScriptPath)' == '' ">$(MSBuildProjectDirectory)/GitVersionMyTest.csx</MyTestScriptPath>
  </PropertyGroup>

  <PropertyGroup>
    <!--
      Ensure GetVersion runs prior to XAML's Markup Compiler in order to have the assembly version available.
      Otherwise the generated resource URI's are ambiguous when multiple versions are loaded simultaneously (i.e. in plugins)
        - copied from GitVersion
    -->
    <MarkupCompilePass1DependsOn>$(MarkupCompilePass1DependsOn);GenerateGitVersionInformationMyTest</MarkupCompilePass1DependsOn>
    <GetPackageVersionDependsOn>$(GetPackageVersionDependsOn);GenerateGitVersionInformationMyTest</GetPackageVersionDependsOn>
  </PropertyGroup>

Another alternative would be modify the gitversion.json file and run the assembly info generator alone. Is that possible?

RepositoryFixture Test

No response

Output log or link to your CI build (if appropriate).

No response

[RobSmyth]

As it happens I found the problem minutes after posting this issue.

It is an SDK 8 feature. See https://stackoverflow.com/questions/77050814/fileversioninfo-productversion-suddenly-contains-git-commit-hash

Fixed by adding this to the project file.

<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>

Thanks ... this can be closed.

[RobSmyth]

For others ... here is further info:

https://learn.microsoft.com/en-us/dotnet/core/compatibility/sdk/8.0/source-link