Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using effective branch configuration #3396

Merged

Conversation

HHobeck
Copy link
Contributor

@HHobeck HHobeck commented Feb 23, 2023

Description

This is a consolidation step in the VersionInBranchNameVersionStrategy class to use the build in effective branch configuration.

Related Issue

#2336

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@arturcic arturcic added this to the 6.x milestone Feb 24, 2023
@HHobeck HHobeck force-pushed the feature/using-effective-branch-configuration branch from 3beab1e to cd1a0ef Compare February 27, 2023 09:20
global.json Outdated Show resolved Hide resolved
@HHobeck
Copy link
Contributor Author

HHobeck commented Feb 27, 2023

This implementation looks good. Please review and merge it to main.

@arturcic arturcic enabled auto-merge February 27, 2023 12:41
@arturcic arturcic self-requested a review February 27, 2023 12:41
@arturcic arturcic merged commit 4c983b8 into GitTools:main Feb 27, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 27, 2023

Thank you @HHobeck for your contribution!

@arturcic arturcic modified the milestones: 6.x, 6.0.0-beta.1 Mar 2, 2023
@arturcic
Copy link
Member

arturcic commented Mar 2, 2023

🎉 This issue has been resolved in version 6.0.0-beta.1 🎉
The release is available on:

Your GitReleaseManager bot 📦🚀

@HHobeck HHobeck deleted the feature/using-effective-branch-configuration branch March 13, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants