When incrementing version using commit message, we only consider tags with a valid version #3889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HHobeck
force-pushed
the
feature/Version-not-bumped-if-an-irrelevant-tag-exists
branch
from
5bf9598 to
a4a2195
Compare
|
Hi @arturcic. If you have time please review and merge this PR. Thank you! |
|
sure, I might have some time this week. |
HHobeck
force-pushed
the
feature/Version-not-bumped-if-an-irrelevant-tag-exists
branch
from
a4a2195 to
158bac4
Compare
arturcic
approved these changes
Feb 6, 2024
|
Thank you @HHobeck for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed method
FindCommitMessageIncrementinIncrementStrategyFinderto consider SHA from tags that have semantic versioning, by reusingGetTaggedSemanticVersionsofIRepositoryStore.The change requires removing the
tagsShaCachesince the discovery must account for the currently usedconfigurationand its prefix.Close #3757
Related Issue
See issue #3757
Motivation and Context
The current behavior won't allow any other tagging (by the CI or users) to co-exist with version bumping commits.
The problem appears when any of the commits attempting to bump the version come before a tag that is not version related.
The current implementation will ignore those commits, assuming it will find a version forcing tag, when in reality there's no version defined in it.
How Has This Been Tested?
Added a new theory in
VersionBumpingScenarios.cswith 5 test cases covering prefixed versions too.Checklist: