Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gitversion/command task/action, remove additionalArguments from gitversion/execute #1203

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

arturcic
Copy link
Member

Currently the gitversion/execute task/action is running internally GitVersion with output parsed as json.

In case there is a need to run GitVersion with some arguments that do not return a json output, just as /showconfig, /showvariable or /format the gitversion/execute task/action will fail. For this reason the additionalArguments was removed from the task/action.

In this PR I added a new gitversion/command task/action to allow to execute the GitVersion tool with additional arguments and the output is consumed but the user as is

@arturcic arturcic added this to the v3.x milestone Jul 24, 2024
@arturcic arturcic force-pushed the feature/gitversion-command branch 15 times, most recently from 276eb2c to de6c57b Compare July 25, 2024 07:16
@arturcic arturcic force-pushed the feature/gitversion-command branch 2 times, most recently from c7bee48 to 0906c25 Compare July 25, 2024 07:47
@arturcic arturcic merged commit 1584efa into GitTools:main Jul 25, 2024
14 checks passed
@arturcic arturcic deleted the feature/gitversion-command branch July 25, 2024 08:21
Copy link
Contributor

mergify bot commented Jul 25, 2024

Thank you @arturcic for your contribution!

@arturcic arturcic added the enhancement New feature or request label Jul 25, 2024
@arturcic arturcic modified the milestones: v3.x, v3.0.0 Jul 25, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants