Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sites support #2262

Merged
merged 11 commits into from
Apr 8, 2024
Merged

Sites support #2262

merged 11 commits into from
Apr 8, 2024

Conversation

taranvohra
Copy link
Member

@taranvohra taranvohra commented Apr 3, 2024 •
edited
Loading

This PR adds support for rendering sites in GitBook Open.

@SamyPesse SamyPesse self-requested a review April 4, 2024 11:54
@taranvohra taranvohra marked this pull request as ready for review April 4, 2024 13:16
@taranvohra taranvohra changed the title [WIP] Sites support Sites support Apr 4, 2024
SamyPesse
SamyPesse approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@SamyPesse SamyPesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should manually test on the preview url a bunch of important GitBook content (with collection, etc) before merging

src/app/(space)/(content)/[[...pathname]]/page.tsx Show resolved Hide resolved
src/app/(space)/fetch.ts Outdated Show resolved Hide resolved
src/components/Search/server-actions.tsx Outdated Show resolved Hide resolved
src/lib/api.ts Show resolved Hide resolved
src/middleware.ts Outdated Show resolved Hide resolved
@taranvohra
Copy link
Member Author

I have manually tested a bunch of collection URLs that seem to be working

@taranvohra taranvohra merged commit 0c22486 into main Apr 8, 2024
6 of 8 checks passed
@taranvohra taranvohra deleted the taran/sites branch April 8, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamyPesse SamyPesse SamyPesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taranvohra @SamyPesse