Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested list support #2562

Merged
merged 3 commits into from
Oct 31, 2024
Merged

Nested list support #2562

merged 3 commits into from
Oct 31, 2024

Conversation

gregberge
Copy link
Contributor

@gregberge gregberge commented Oct 30, 2024 •
edited
Loading

Before
CleanShot 2024-10-30 at 15 27 19@2x

After
CleanShot 2024-10-30 at 15 27 44@2x

Heading in list before
CleanShot 2024-10-30 at 15 46 51@2x

Heading in list after
CleanShot 2024-10-30 at 15 48 03@2x

@linear Linear
Copy link

linear bot commented Oct 30, 2024

RND-5433 Support nested lists in GBO

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 30, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 53adde8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 30, 2024 •
edited
Loading

GitBook Preview
Latest commit: https://473ea71b.gitbook-open.pages.dev
PR: https://pr2562.gitbook-open.pages.dev

@argos-ci Argos CI
Copy link

argos-ci bot commented Oct 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 26 changed Oct 31, 2024, 12:58 PM

@gregberge gregberge force-pushed the greg/rnd-5433-support-nested-lists-in-gbo branch from c703bca to 16a6b71 Compare October 30, 2024 14:48
@gregberge gregberge force-pushed the greg/rnd-5433-support-nested-lists-in-gbo branch from 38e1cdf to 30752f2 Compare October 31, 2024 10:52
BrettJephson
BrettJephson approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@BrettJephson BrettJephson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

packages/gitbook/src/components/DocumentView/ListItem.tsx Show resolved Hide resolved
@gregberge gregberge merged commit 54a797a into main Oct 31, 2024
9 checks passed
@gregberge gregberge deleted the greg/rnd-5433-support-nested-lists-in-gbo branch October 31, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrettJephson BrettJephson BrettJephson approved these changes

@SamyPesse SamyPesse Awaiting requested review from SamyPesse

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gregberge @BrettJephson