Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use getPublishedContentSite API #2570

Merged
merged 4 commits into from
Nov 15, 2024
Merged

Conversation

taranvohra
Copy link
Member

@taranvohra taranvohra commented Nov 14, 2024

This PR is an attempt to reduce to number of API calls while rendering published content now that getPublishedContentSite gives us all the relevant data in one call.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 8793338

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 14, 2024

GitBook Preview
Latest commit: https://5927cd26.gitbook-open.pages.dev
PR: https://pr2570.gitbook-open.pages.dev

Copy link

argos-ci bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) ⚠️ Changes detected (Review) 10 changed Dec 31, 2024, 11:12 PM

@taranvohra taranvohra marked this pull request as ready for review November 14, 2024 12:34
packages/gitbook/src/app/(space)/~gitbook/pdf/layout.tsx Outdated Show resolved Hide resolved
packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved
packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved
packages/gitbook/src/lib/api.ts Show resolved Hide resolved
packages/gitbook/src/lib/api.ts Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@taranvohra taranvohra requested a review from SamyPesse November 14, 2024 14:03
@SamyPesse SamyPesse merged commit 7675c2c into main Nov 15, 2024
9 checks passed
@SamyPesse SamyPesse deleted the taran/getPublishedContentSite branch November 15, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants