Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user comments after rating #2771

Merged
merged 4 commits into from
Jan 28, 2025

Conversation

zenoachtig
Copy link
Contributor

@zenoachtig zenoachtig commented Jan 23, 2025

Screen.Recording.2025-01-23.at.13.48.34.mov

To do

  • Hook up API and typing to accept comment prop (in trackEvent() and createSitesPageFeedback() – marked with // TODO @Samy in the code.
  • Serverside validation and escaping of user input. The only check I've built so far is a client side maxLength, but I don't escape the value in any way right now.
  • Add some tests?

Copy link

linear bot commented Jan 23, 2025

Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: 0ecfdf1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
gitbook Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@zenoachtig
Copy link
Contributor Author

@SamyPesse It's ready for you, feel free to take over. Lmk if you need anything else 👌

Copy link
Contributor

github-actions bot commented Jan 23, 2025

GitBook Preview
Latest commit: https://822b1ca8.gitbook-open.pages.dev
PR: https://pr2771.gitbook-open.pages.dev

Copy link

argos-ci bot commented Jan 23, 2025

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 291 changed, 1 failure Jan 28, 2025, 8:38 AM

@SamyPesse SamyPesse marked this pull request as ready for review January 28, 2025 08:34
@SamyPesse SamyPesse merged commit f7b801b into main Jan 28, 2025
8 of 9 checks passed
@SamyPesse SamyPesse deleted the zeno/rnd-5991-support-user-comments-after-rating branch January 28, 2025 08:39
RaspingMango added a commit to RaspingMango/gitbook that referenced this pull request Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants