Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop "MIT License" line from LICENSE-MIT #1097

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

martinvonz
Copy link
Contributor

@martinvonz martinvonz commented Nov 9, 2023

Since jj now uses gitoxide, I need to import many gitoxide crates into Google's source control system. The automation at Google doesn't like the "MIT License" line at the beginning of the LICENSE-MIT file. AFAICT, the automation is correct in thinking that the line is not supposed to be there.

Since jj now uses gitoxide, I'm need to import many gitoxide crates into Google's source control system. The automation at Google doesn't like the "MIT License" line at the beginning of the LICENSE-MIT file. AFAICT, the automation is correct in thinking that the line is not supposed to be there.
Copy link
Member

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, much appreciated!

@Byron Byron merged commit 7825637 into GitoxideLabs:main Nov 9, 2023
3 checks passed
martinvonz added a commit to martinvonz/clru-rs that referenced this pull request Nov 11, 2023
I was importing this crate into Google's source control system. The
automation at Google doesn't like the "MIT License" line at the
beginning of the LICENSE-MIT file. AFAICT, the automation is correct
in thinking that the line is not supposed to be there.

For reference, I've made the same change in gitoxide:
GitoxideLabs/gitoxide#1097
marmeladema pushed a commit to marmeladema/clru-rs that referenced this pull request May 2, 2024
I was importing this crate into Google's source control system. The
automation at Google doesn't like the "MIT License" line at the
beginning of the LICENSE-MIT file. AFAICT, the automation is correct
in thinking that the line is not supposed to be there.

For reference, I've made the same change in gitoxide:
GitoxideLabs/gitoxide#1097
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants