Fix stat on files with timestamps before the epoch #1250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stat converted the seconds to a `u64` before converting them to SystemTime. This would cause timestamps before the epoch to wrap around to timestamps near `u64::MAX`. Instead, pass the seconds as an i64. Convert it to SystemTime by computing an absolute Duration and then adding or subtracting as appropriate.
Byron
force-pushed
the
fix-stat-with-negative-times
branch
from
2634440 to
3cd6a41
Compare
Byron
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Thanks a lot!
I have added the test which exposed yet another issue specific to MacOS, and one that fortunately we already encountered and solved :D.
Will merge when CI is green and create a new release of gix-index which fortunately didn't encounter any breaking changes, making a patch-release possible.
Byron
force-pushed
the
fix-stat-with-negative-times
branch
from
3cd6a41 to
7ce455c
Compare
Copied from https://github.com/rust-lang/rust at a8ece1190bf6b340175bc5b688e52bd29924f483
Byron
force-pushed
the
fix-stat-with-negative-times
branch
from
7ce455c to
bf49cd4
Compare
|
Now there is bytecodealliance/rustix#990 which, if accepted, would probably alleviate the need to cast to |
|
And finally, the there is a new release with the fix: https://github.com/Byron/gitoxide/releases/tag/gix-index-v0.28.2 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stat converted the seconds to a
u64before converting them toSystemTime. This would cause timestamps before the epoch to wrap around
to timestamps near
u64::MAX.Instead, pass the seconds as an i64. Convert it to SystemTime by
computing an absolute Duration and then adding or subtracting as
appropriate.